From a53cb5ee6e104303f24ab70b7cbba9f4ac718c6b Mon Sep 17 00:00:00 2001 From: Etienne Millon Date: Thu, 6 Jul 2023 09:16:10 +0200 Subject: [PATCH] fix: disable threaded console when we use fork This is similar to #8100 for the threaded console. The reason we're doing that is to avoid threads when fork is involved. Signed-off-by: Etienne Millon --- CHANGES.md | 4 ++-- src/dune_config/config.ml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index 8c44f50eed5..9e41a5b400b 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,8 +1,8 @@ Unreleased ---------- -- Disable background operations on MacOS and other Unixes where we rely on - fork. (#8100, fixes #8083, @rgrinberg) +- Disable background operations and threaded console on MacOS and other Unixes + where we rely on fork. (#8100, #8121, fixes #8083, @rgrinberg, @emillon) - Add `dune build --dump-gc-stats FILE` argument to dump Garbage Collection stats to a named file. (#8072, @Alizter) diff --git a/src/dune_config/config.ml b/src/dune_config/config.ml index 1b43d3b3a76..eac22094920 100644 --- a/src/dune_config/config.ml +++ b/src/dune_config/config.ml @@ -146,7 +146,7 @@ let threaded_console = let t = { name = "threaded_console" ; of_string = Toggle.of_string - ; value = `Enabled + ; value = background_default } in register t;