Throw an Error instead of a string when there's a contract violation #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JS has deprecated throwing strings and many (all?) testing environments don't produce stack traces for thrown strings.
|
BTW, I ran |
|
thank you! previously i picked "rebase and merge" i think. |
|
Ah. Both of those will change the commit hash, I believe. Going forward, would you be ok doing a regular merge (ie, no squash or rebase)?
…On Mon, Sep 26, 2022 at 12:57 PM, emmanueltouzery < ***@***.*** > wrote:
thank you! previously i picked "rebase and merge" i think.
this time "squash and merge"... just FYI.
—
Reply to this email directly, view it on GitHub (
#65 (comment)
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AAAOIXN4HGA6445M5BDD2U3WAH52PANCNFSM6AAAAAAQWC6YF4
).
You are receiving this because you authored the thread. Message ID: <emmanueltouzery/prelude-ts/pull/65/c1258547238
@ github. com>
|
|
with an extra merge commit? sure, if it offers me i'll do it. |
|
Thanks! I think that will make this quite a bit smoother on my end.
…On Mon, Sep 26, 2022 at 1:08 PM, emmanueltouzery < ***@***.*** > wrote:
with an extra merge commit? sure, if it offers me i'll do it.
—
Reply to this email directly, view it on GitHub (
#65 (comment)
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AAAOIXO2C6NN7NQLI32JAOTWAH7DLANCNFSM6AAAAAAQWC6YF4
).
You are receiving this because you authored the thread. Message ID: <emmanueltouzery/prelude-ts/pull/65/c1258558989
@ github. com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default to throw an Error when there's a contact violation
As described in #59, this means that we get stack traces in testing environments when preludeTsContractViolationCb is called.