From 692b73fd9291eb19bc2a9ebdb37a647e37c94507 Mon Sep 17 00:00:00 2001
From: acondal <annac@empathy.co>
Date: Wed, 30 Aug 2023 15:22:06 +0200
Subject: [PATCH 1/7] feat: change eslint max-len config for vue files

EMP-1907
---
 .eslintrc.js | 47 ++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 46 insertions(+), 1 deletion(-)

diff --git a/.eslintrc.js b/.eslintrc.js
index 93e2671967..c87610ba13 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -12,5 +12,50 @@ module.exports = {
   parserOptions: {
     tsconfigRootDir: __dirname,
     project: './packages/**/tsconfig.eslint.json'
-  }
+  },
+  overrides: [
+    {
+      files: ['*.vue'],
+      rules: {
+        /*
+         * We disable "max-len" rule to ".vue" files because it has some limitations
+         * https://github.com/vuejs/vue-eslint-parser#%EF%B8%8F-known-limitations.
+         *
+         * Instead we use the one that "eslint-plugin-vue" has. This rule understands much better
+         * the ".vue" files.
+         * It helps us in cases that the "<style>" tag's section has long lines of
+         * code.
+         * (e.g: "@include foo(background-color, color, $selector: '#{$component-class}__kpi');
+         * https://github.com/vuejs/eslint-plugin-vue/blob/master/docs/rules/max-len.md
+         */
+        'max-len': 'off',
+        'vue/max-len': [
+          'error',
+          {
+            ignoreStrings: true,
+            ignoreTemplateLiterals: true,
+            ignoreUrls: true,
+            /*
+             * "ignoreHTMLAttributeValues" helps us when an attribute is too long, and it does not fit in the defined max-len
+             * but prettier wouldn't want to wrap it in multiple lines.
+             * Pretty useful when the "class" attribute is too long.
+             * e.g:
+             * - "<div  class="example-component example-component--expanded">.
+             * - "<path
+             *     d="M11 .5c-1.7.2-3.4.9-4.7 2-1.1.9-2 2-2.5 3.2-1.2 2.4-1.2 5.1-.1 7.7 1.1 2.6 2.8 5 5.3 7.5 1.2 1.2 2.8 2.7 3 2.7 0 0
+             *    />"
+             *
+             * Previously prettier would have formatted this with one class per line. like so:
+             * "<div class="example-component
+             *             example-component--expanded"
+             * >"
+             * But it is no longer an option since prettier@2.5.0.
+             * https://prettier.io/blog/2021/11/25/2.5.0.html#collapse-html-class-attributes-onto-one-line-11827httpsgithubcomprettierprettierpull11827-by-jlongsterhttpsgithubcomjlongster
+             */
+            ignoreHTMLAttributeValues: true
+          }
+        ]
+      }
+    }
+  ]
 };

From f6cce97cd7e7d1f3c88bd3cc92fad18716befbc2 Mon Sep 17 00:00:00 2001
From: acondal <annac@empathy.co>
Date: Wed, 30 Aug 2023 15:24:32 +0200
Subject: [PATCH 2/7] feat: /* eslint-disable max-len */ can be removed from
 vue Components

EMP-1907
---
 packages/x-components/src/views/home/Home.vue                   | 1 -
 packages/x-components/src/views/home/aside.vue                  | 2 --
 .../x-components/src/x-modules/tagging/components/tagging.vue   | 2 +-
 3 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/packages/x-components/src/views/home/Home.vue b/packages/x-components/src/views/home/Home.vue
index 953241aa72..4d165082b4 100644
--- a/packages/x-components/src/views/home/Home.vue
+++ b/packages/x-components/src/views/home/Home.vue
@@ -428,7 +428,6 @@
 </template>
 
 <script lang="ts">
-  /* eslint-disable max-len */
   import Vue from 'vue';
   import { Component } from 'vue-property-decorator';
   import { animateClipPath } from '../../components/animations/animate-clip-path/animate-clip-path.factory';
diff --git a/packages/x-components/src/views/home/aside.vue b/packages/x-components/src/views/home/aside.vue
index ed85e226b8..313c60a72b 100644
--- a/packages/x-components/src/views/home/aside.vue
+++ b/packages/x-components/src/views/home/aside.vue
@@ -129,7 +129,6 @@
 </template>
 
 <script lang="ts">
-  /* eslint-disable max-len */
   import {
     EditableNumberRangeFacet,
     EditableNumberRangeFilter,
@@ -156,7 +155,6 @@
   import SlicedFilters from '../../x-modules/facets/components/lists/sliced-filters.vue';
   import SortedFilters from '../../x-modules/facets/components/lists/sorted-filters.vue';
   import { HomeControls } from './types';
-  /* eslint-enable max-len */
 
   @Component({
     components: {
diff --git a/packages/x-components/src/x-modules/tagging/components/tagging.vue b/packages/x-components/src/x-modules/tagging/components/tagging.vue
index 1bf0651628..7813f8a14c 100644
--- a/packages/x-components/src/x-modules/tagging/components/tagging.vue
+++ b/packages/x-components/src/x-modules/tagging/components/tagging.vue
@@ -6,7 +6,7 @@
   import { SnippetConfig } from '../../../x-installer/api/api.types';
   import { taggingXModule } from '../x-module';
   import { TaggingConfig } from '../config.types';
-  /* eslint-disable max-len */
+
   /**
    * This component enables and manages the sending of information to the
    * [Empathy Tagging API](https://docs.empathy.co/develop-empathy-platform/api-reference/tagging-api.html).

From 996a7e6b1a9224d1d01b163367264292c0c4c04c Mon Sep 17 00:00:00 2001
From: acondal <annac@empathy.co>
Date: Thu, 31 Aug 2023 14:57:44 +0200
Subject: [PATCH 3/7] feat: rm overrides from here, they will be set in
 eslint-x plugin

EMP-1907
---
 .eslintrc.js | 47 +----------------------------------------------
 1 file changed, 1 insertion(+), 46 deletions(-)

diff --git a/.eslintrc.js b/.eslintrc.js
index c87610ba13..93e2671967 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -12,50 +12,5 @@ module.exports = {
   parserOptions: {
     tsconfigRootDir: __dirname,
     project: './packages/**/tsconfig.eslint.json'
-  },
-  overrides: [
-    {
-      files: ['*.vue'],
-      rules: {
-        /*
-         * We disable "max-len" rule to ".vue" files because it has some limitations
-         * https://github.com/vuejs/vue-eslint-parser#%EF%B8%8F-known-limitations.
-         *
-         * Instead we use the one that "eslint-plugin-vue" has. This rule understands much better
-         * the ".vue" files.
-         * It helps us in cases that the "<style>" tag's section has long lines of
-         * code.
-         * (e.g: "@include foo(background-color, color, $selector: '#{$component-class}__kpi');
-         * https://github.com/vuejs/eslint-plugin-vue/blob/master/docs/rules/max-len.md
-         */
-        'max-len': 'off',
-        'vue/max-len': [
-          'error',
-          {
-            ignoreStrings: true,
-            ignoreTemplateLiterals: true,
-            ignoreUrls: true,
-            /*
-             * "ignoreHTMLAttributeValues" helps us when an attribute is too long, and it does not fit in the defined max-len
-             * but prettier wouldn't want to wrap it in multiple lines.
-             * Pretty useful when the "class" attribute is too long.
-             * e.g:
-             * - "<div  class="example-component example-component--expanded">.
-             * - "<path
-             *     d="M11 .5c-1.7.2-3.4.9-4.7 2-1.1.9-2 2-2.5 3.2-1.2 2.4-1.2 5.1-.1 7.7 1.1 2.6 2.8 5 5.3 7.5 1.2 1.2 2.8 2.7 3 2.7 0 0
-             *    />"
-             *
-             * Previously prettier would have formatted this with one class per line. like so:
-             * "<div class="example-component
-             *             example-component--expanded"
-             * >"
-             * But it is no longer an option since prettier@2.5.0.
-             * https://prettier.io/blog/2021/11/25/2.5.0.html#collapse-html-class-attributes-onto-one-line-11827httpsgithubcomprettierprettierpull11827-by-jlongsterhttpsgithubcomjlongster
-             */
-            ignoreHTMLAttributeValues: true
-          }
-        ]
-      }
-    }
-  ]
+  }
 };

From 859799b718505d5c4ac9d54935e3117f3afe69c8 Mon Sep 17 00:00:00 2001
From: acondal <annac@empathy.co>
Date: Thu, 31 Aug 2023 14:58:56 +0200
Subject: [PATCH 4/7] feat: disable max-len in eslint-pluggin-vue config, rm
 overrides to hold them in eslint-x pluggin

EMP-1907
---
 .../eslint-plugin-x/lib/configs/eslint.js     | 45 ++++++++++++++++++-
 1 file changed, 44 insertions(+), 1 deletion(-)

diff --git a/packages/eslint-plugin-x/lib/configs/eslint.js b/packages/eslint-plugin-x/lib/configs/eslint.js
index 53481473e7..afd9e7b598 100644
--- a/packages/eslint-plugin-x/lib/configs/eslint.js
+++ b/packages/eslint-plugin-x/lib/configs/eslint.js
@@ -7,6 +7,7 @@ module.exports = {
       curly: ['error', 'all'],
       eqeqeq: ['error', 'always', { null: 'ignore' }],
       indent: 'off',
+      // THESE 'max-len' rules ARE ALMOST THE SAME OVERRIDE CONFIG THAT IS SET IN x-components/.eslintrc.js for vue files, except the ignorePattern, so we will override it below in vue files
       'max-len': ['error', { code: 100, ignoreComments: false, ignorePattern: 'class=".*"$' }],
       'no-alert': process.env.NODE_ENV === 'production' ? 'error' : 'off',
       'no-console': process.env.NODE_ENV === 'production' ? 'error' : 'off',
@@ -23,6 +24,48 @@ module.exports = {
       'require-atomic-updates': 'error',
       'require-await': 'error',
       strict: ['error', 'global']
-    }
+    },
+    overrides: [
+      {
+        files: ['src/**/*.vue'],
+        rules: {
+          /*
+           * We use 'vue/max-len' that "eslint-plugin-vue" has. This rule understands much better
+           * the ".vue" files.
+           * It helps us in cases that the "<style>" tag's section has long lines of
+           * code.
+           * (e.g: "@include foo(background-color, color, $selector: '#{$component-class}__kpi');
+           * https://github.com/vuejs/eslint-plugin-vue/blob/master/docs/rules/max-len.md
+           */
+          'vue/max-len': [
+            'error',
+            {
+              ignorePattern: '|class=".*"$ |https://github',
+              ignoreStrings: true,
+              ignoreTemplateLiterals: true,
+              ignoreUrls: true,
+              /*
+               * "ignoreHTMLAttributeValues" helps us when an attribute is too long, and it does not fit in the defined max-len
+               * but prettier wouldn't want to wrap it in multiple lines.
+               * Pretty useful when the "class" attribute is too long.
+               * e.g:
+               * - "<div  class="example-component example-component--expanded">.
+               * - "<path
+               *     d="M11 .5c-1.7.2-3.4.9-4.7 2-1.1.9-2 2-2.5 3.2-1.2 2.4-1.2 5.1-.1 7.7 1.1 2.6 2.8 5 5.3 7.5 1.2 1.2 2.8 2.7 3 2.7 0 0
+               *    />"
+               *
+               * Previously prettier would have formatted this with one class per line. like so:
+               * "<div class="example-component
+               *             example-component--expanded"
+               * >"
+               * But it is no longer an option since prettier@2.5.0.
+               * https://prettier.io/blog/2021/11/25/2.5.0.html#collapse-html-class-attributes-onto-one-line-11827httpsgithubcomprettierprettierpull11827-by-jlongsterhttpsgithubcomjlongster
+               */
+              ignoreHTMLAttributeValues: true
+            }
+          ]
+        }
+      }
+    ]
   }
 };

From 9b26f949f8816ac877121fdeffc477c81c67a02d Mon Sep 17 00:00:00 2001
From: acondal <annac@empathy.co>
Date: Thu, 31 Aug 2023 14:59:55 +0200
Subject: [PATCH 5/7] feat: disable max-len in eslint-pluggin-vue config, rm
 overrides to hold them in eslint-x pluggin

EMP-1907
---
 packages/x-components/.eslintrc.js | 19 +++++--------------
 1 file changed, 5 insertions(+), 14 deletions(-)

diff --git a/packages/x-components/.eslintrc.js b/packages/x-components/.eslintrc.js
index 0681013463..fb1384b000 100644
--- a/packages/x-components/.eslintrc.js
+++ b/packages/x-components/.eslintrc.js
@@ -12,21 +12,12 @@ module.exports = {
   },
   overrides: [
     {
-      files: 'src/**/*.vue',
-      rules: {
-        'max-len': [
-          'error',
-          {
-            code: 100,
-            ignoreComments: false,
-            ignorePattern: '|class=".*"$ |https://github'
-          }
-        ]
-      }
-    },
-    {
-      files: 'src/components/icons/*.vue',
+      files: ['src/**/*.vue'],
       rules: {
+        /*
+         * We disable "max-len" rule to ".vue" files because it has some limitations
+         * https://github.com/vuejs/vue-eslint-parser#%EF%B8%8F-known-limitations.
+         */
         'max-len': 'off'
       }
     }

From 97ad5cfc7893d72b043c51d63fb0d0a84cdc2564 Mon Sep 17 00:00:00 2001
From: acondal <annac@empathy.co>
Date: Thu, 31 Aug 2023 15:00:36 +0200
Subject: [PATCH 6/7] feat: set overrides in eslint-x plugin, integrate custom
 ignorePattern that was applied in x-components package config

EMP-1907
---
 .../eslint-plugin-x/lib/configs/eslint.js     | 50 ++-----------------
 packages/eslint-plugin-x/lib/configs/vue.js   | 12 ++++-
 packages/x-components/.eslintrc.js            |  6 +--
 3 files changed, 17 insertions(+), 51 deletions(-)

diff --git a/packages/eslint-plugin-x/lib/configs/eslint.js b/packages/eslint-plugin-x/lib/configs/eslint.js
index afd9e7b598..fa112336ad 100644
--- a/packages/eslint-plugin-x/lib/configs/eslint.js
+++ b/packages/eslint-plugin-x/lib/configs/eslint.js
@@ -7,8 +7,10 @@ module.exports = {
       curly: ['error', 'all'],
       eqeqeq: ['error', 'always', { null: 'ignore' }],
       indent: 'off',
-      // THESE 'max-len' rules ARE ALMOST THE SAME OVERRIDE CONFIG THAT IS SET IN x-components/.eslintrc.js for vue files, except the ignorePattern, so we will override it below in vue files
-      'max-len': ['error', { code: 100, ignoreComments: false, ignorePattern: 'class=".*"$' }],
+      'max-len': [
+        'error',
+        { code: 100, ignoreStrings: true, ignoreTemplateLiterals: true, ignoreUrls: true }
+      ],
       'no-alert': process.env.NODE_ENV === 'production' ? 'error' : 'off',
       'no-console': process.env.NODE_ENV === 'production' ? 'error' : 'off',
       'no-debugger': process.env.NODE_ENV === 'production' ? 'error' : 'off',
@@ -24,48 +26,6 @@ module.exports = {
       'require-atomic-updates': 'error',
       'require-await': 'error',
       strict: ['error', 'global']
-    },
-    overrides: [
-      {
-        files: ['src/**/*.vue'],
-        rules: {
-          /*
-           * We use 'vue/max-len' that "eslint-plugin-vue" has. This rule understands much better
-           * the ".vue" files.
-           * It helps us in cases that the "<style>" tag's section has long lines of
-           * code.
-           * (e.g: "@include foo(background-color, color, $selector: '#{$component-class}__kpi');
-           * https://github.com/vuejs/eslint-plugin-vue/blob/master/docs/rules/max-len.md
-           */
-          'vue/max-len': [
-            'error',
-            {
-              ignorePattern: '|class=".*"$ |https://github',
-              ignoreStrings: true,
-              ignoreTemplateLiterals: true,
-              ignoreUrls: true,
-              /*
-               * "ignoreHTMLAttributeValues" helps us when an attribute is too long, and it does not fit in the defined max-len
-               * but prettier wouldn't want to wrap it in multiple lines.
-               * Pretty useful when the "class" attribute is too long.
-               * e.g:
-               * - "<div  class="example-component example-component--expanded">.
-               * - "<path
-               *     d="M11 .5c-1.7.2-3.4.9-4.7 2-1.1.9-2 2-2.5 3.2-1.2 2.4-1.2 5.1-.1 7.7 1.1 2.6 2.8 5 5.3 7.5 1.2 1.2 2.8 2.7 3 2.7 0 0
-               *    />"
-               *
-               * Previously prettier would have formatted this with one class per line. like so:
-               * "<div class="example-component
-               *             example-component--expanded"
-               * >"
-               * But it is no longer an option since prettier@2.5.0.
-               * https://prettier.io/blog/2021/11/25/2.5.0.html#collapse-html-class-attributes-onto-one-line-11827httpsgithubcomprettierprettierpull11827-by-jlongsterhttpsgithubcomjlongster
-               */
-              ignoreHTMLAttributeValues: true
-            }
-          ]
-        }
-      }
-    ]
+    }
   }
 };
diff --git a/packages/eslint-plugin-x/lib/configs/vue.js b/packages/eslint-plugin-x/lib/configs/vue.js
index 0ee6897a22..6a681941ff 100644
--- a/packages/eslint-plugin-x/lib/configs/vue.js
+++ b/packages/eslint-plugin-x/lib/configs/vue.js
@@ -35,7 +35,17 @@ module.exports = {
       'vue/component-tags-order': 'warn',
       'vue/v-on-function-call': 'error',
       'vue/v-slot-style': 'off',
-      'vue/valid-v-slot': 'warn'
+      'vue/valid-v-slot': 'warn',
+      'vue/max-len': [
+        'error',
+        {
+          code: 100,
+          ignoreStrings: true,
+          ignoreTemplateLiterals: true,
+          ignoreUrls: true,
+          ignoreHTMLAttributeValues: true
+        }
+      ]
     }
   }
 };
diff --git a/packages/x-components/.eslintrc.js b/packages/x-components/.eslintrc.js
index fb1384b000..629cf3e5d8 100644
--- a/packages/x-components/.eslintrc.js
+++ b/packages/x-components/.eslintrc.js
@@ -12,12 +12,8 @@ module.exports = {
   },
   overrides: [
     {
-      files: ['src/**/*.vue'],
+      files: ['*.vue'],
       rules: {
-        /*
-         * We disable "max-len" rule to ".vue" files because it has some limitations
-         * https://github.com/vuejs/vue-eslint-parser#%EF%B8%8F-known-limitations.
-         */
         'max-len': 'off'
       }
     }

From 4e0d6b10f3b9fe486bb0e3e5c1047b4ca0983913 Mon Sep 17 00:00:00 2001
From: acondal <annac@empathy.co>
Date: Fri, 1 Sep 2023 10:20:36 +0200
Subject: [PATCH 7/7] feat: set ignorePattern to ignore classes globally as it
 affects to tailwind plugin

EMP-1907
---
 packages/eslint-plugin-x/lib/configs/eslint.js | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/packages/eslint-plugin-x/lib/configs/eslint.js b/packages/eslint-plugin-x/lib/configs/eslint.js
index fa112336ad..9bf07f0c4a 100644
--- a/packages/eslint-plugin-x/lib/configs/eslint.js
+++ b/packages/eslint-plugin-x/lib/configs/eslint.js
@@ -9,7 +9,13 @@ module.exports = {
       indent: 'off',
       'max-len': [
         'error',
-        { code: 100, ignoreStrings: true, ignoreTemplateLiterals: true, ignoreUrls: true }
+        {
+          code: 100,
+          ignoreStrings: true,
+          ignoreTemplateLiterals: true,
+          ignoreUrls: true,
+          ignorePattern: 'class=".*"$'
+        }
       ],
       'no-alert': process.env.NODE_ENV === 'production' ? 'error' : 'off',
       'no-console': process.env.NODE_ENV === 'production' ? 'error' : 'off',