[embind] Add #if ASSERTIONS guard around assert calls

Supersedes #20504

Author: sbc100

ChangeLog.md

@@ -20,6 +20,10 @@ See docs/process.md for more on how version tagging works.
 
 3.1.48 (in development)
 -----------------------
+- The JS `assert` function is no longer available in release builds when
+  `-sSTRICT` is used.  This should only affect users with custom JS library code
+  which doesn't use `#if ASSERTIONS` guards around their `assert` calls.  This
+  behaviour matches that of `MINIMAL_RUNTIME`. (#20592)
 - The minimum version of node required run the compiler was updated from
   10.19 to 16.20.  This does not effect the node requirements of the generated
   JavaScript code. (#20551)

src/embind/embind_shared.js

@@ -129,7 +129,9 @@ var LibraryEmbindShared = {
     signature = signature.trim();
     const argsIndex = signature.indexOf("(");
     if (argsIndex !== -1) {
+#if ASSERTIONS
       assert(signature[signature.length - 1] == ")", "Parentheses for argument names should match.");
+#endif
       return signature.substr(0, argsIndex);
     } else {
       return signature;
@@ -140,7 +142,9 @@ var LibraryEmbindShared = {
     signature = signature.trim();
     const argsIndex = signature.indexOf("(") + 1;
     if (argsIndex !== 0) {
+#if ASSERTIONS
       assert(signature[signature.length - 1] == ")", "Parentheses for argument names should match.");
+#endif
       return signature.substr(argsIndex, signature.length - argsIndex - 1).replaceAll(" ", "").split(",").filter(n => n.length);
     } else {
       return [];

src/library_pthread.js

@@ -592,7 +592,9 @@ var LibraryPThread = {
       PThread.outstandingPromises[pthread_ptr].resolve();
     }
 #endif
+#if ASSERTIONS
     assert(worker);
+#endif
     PThread.returnWorkerToPool(worker);
   },
 

test/test_other.py

@@ -2892,9 +2892,11 @@ def test_embind_closure_no_dynamic_execution(self):
         emscripten::function("bar", &bar);
       }
     ''')
-    self.emcc_args.remove('-Wclosure')
+    self.set_setting('INCOMING_MODULE_JS_API', 'onRuntimeInitialized')
+    self.set_setting('STRICT')
+    self.set_setting('NO_DYNAMIC_EXECUTION')
     self.do_runf('main.cpp', '10\nok\n',
-                 emcc_args=['-lembind', '-O2', '--closure', '1', '-sNO_DYNAMIC_EXECUTION', '--post-js', 'post.js'])
+                 emcc_args=['--no-entry', '-lembind', '-O2', '--closure=1', '--minify=0', '--post-js=post.js'])
 
   @is_slow_test
   @parameterized({