Assert on proper alignment in dlmalloc #14634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
Jul 12, 2021
| _Static_assert(MALLOC_ALIGNMENT == 8, "max_align_t must be 8"); | ||
| #endif | ||
|
|
||
| #endif // __EMSCRIPTEN__ |
Collaborator
There was a problem hiding this comment.
This same code should be used in emmalloc too?
sbc100
reviewed
Jul 12, 2021
system/lib/emmalloc.cpp
Outdated
|
|
||
| // Configuration: specifies the minimum alignment that malloc()ed memory outputs. Allocation requests with smaller alignment | ||
| // than this will yield an allocation with this much alignment. | ||
| #define MALLOC_ALIGNMENT 8 |
Collaborator
There was a problem hiding this comment.
How about
#define MALLOC_ALIGNMENT alignof(max_align_t)
_Static_assert(alignof(max_align_t) == 8, "max_align_t must be correct");
Note that in C++ you can do alignof rather than __alignof__
sbc100
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10072