Skip to content

Enable webidl_binder.py to not generate asserts #21201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VirtualTim wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable webidl_binder.py to not generate asserts #21201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions tools/webidl_binder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,19 +214,31 @@ def build_constructor(name):
if (!ensureCache.buffer) { // happens first time, or when we need to grow
ensureCache.size += 128; // heuristic, avoid many small grow events
ensureCache.buffer = Module['_webidl_malloc'](ensureCache.size);
assert(ensureCache.buffer);
''']
if CHECKS == 'ALL':
mid_js += [" assert(ensureCache.buffer);"]

mid_js += ['''
}
ensureCache.pos = 0;
},
alloc(array, view) {
assert(ensureCache.buffer);
''']
if CHECKS == 'ALL':
mid_js += [" assert(ensureCache.buffer);"]

mid_js += ['''
var bytes = view.BYTES_PER_ELEMENT;
var len = array.length * bytes;
len = alignMemory(len, 8); // keep things aligned to 8 byte boundaries
var ret;
if (ensureCache.pos + len >= ensureCache.size) {
// we failed to allocate in the buffer, ensureCache time around :(
assert(len > 0); // null terminator, at least
''']
if CHECKS == 'ALL':
mid_js += [" assert(len > 0); // null terminator, at least"]

mid_js += ['''
ensureCache.needed += len;
ret = Module['_webidl_malloc'](len);
ensureCache.temps.push(ret);
Expand Down