-
-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 0.28.0 #3404
Version 0.28.0 #3404
Conversation
@tomchristie How would I supply a custom root certificate if a dependency is using httpx but does not allow a custom context to be passed? So far we have used |
@agrueneberg Thanks. You would need the dependency to support passing an ssl context through, if you wanted to use a custom context... Can you describe your setup just a little more? |
@agrueneberg Thanks. You would need the dependency to support passing an ssl context through, if you wanted to use a custom context... Good pointer towards why we might want to switch to truststore over certifi. Perhaps you could take a look at #3409 and see if that'd resolve things for you. |
Sorry for the late response. Our dependency (qdrant-client) does in fact pass additional arguments to httpx, so the problem is not as bad as I thought. I still liked the configuration-free approach that Truststore appears to be a step in the right direction. |
That said, I've never seen a code snippet where an explicit SSLContext is passed as an argument to |
@agrueneberg That's a concession I'd be happy for us to take for a 0.28.0 release. Are you interested in issuing a PR resolving that? |
Godspeed, thanks for hearing me out :)
|
Okay, as much as I'd like to push forward with this quickly we really need a deprecation path rather than hard breakages here. So... #3419 |
Hey team. 👋🏼
Alrighty we've got ourselves a release here. I think this strikes the right balance between pushing forwards towards an improved and simplified 1.0 release while minimising disruption in getting there.
0.28.0 (15th November, 2024)
The 0.28 release includes a limited set of backwards incompatible changes.
Backwards incompatible changes:
SSL configuration has been significantly simplified.
verify
argument no longer accepts string arguments.cert
argument has now been removed.SSL_CERT_FILE
andSSL_CERT_DIR
environment variables are no longer automatically used.For users of the standard
verify=True
orverify=False
cases this should require no changes.For information on configuring more complex SSL cases, please see the SSL documentation.
The following changes are also included:
URL.raw
property has now been deprecated, and will raise warnings.proxies
argument has now been removed.app
argument has now been removed.certifi
andhttpcore
are only imported if required. (made dependencies on certifi and httpcore only load when required #3377)socks5h
as a valid proxy scheme. (add socks5h proxy support #3178)Request()
method signature in line withclient.request()
andhttpx.request()
. (CleanupRequest
method parameter. #3378)