request.client broken in version 0.35.0?

[jsoques]

I have been using request.client.host previously and when upgraded to 0.35.0 client is always 'None'. I have been using it to obtain the clients address as indicated here: https://www.starlette.io/requests/. I have reverted back to version 0.32.0.post1. This occurs when using TestClient only apparently so my tests are broken (testing FastAPI project).

[Kludex]

That is the intended behavior.

[VenturaParade]

If anyone got here wondering why or how to fix, I think this is the cause.
An easy fix is just to do request.client.host if request.client else None, since this behavior is exclusive to the test client

[pythonweb2]

@Kludex can you make it optional to set the test client to None? We have a lot of tests that relied on it being populated for logging. ☹️

[blaise-io]

It's reverted (for now), see #2525

[pythonweb2]

This change was in 0.37.2