Implement access log format #1191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…access-log-format
|
It'd be really nice to get this merged. Would save a lot of overengineering to add custom headers to access log. Is there any workaround as of now for this use-case? |
|
Yep, erasing the current "uvicorn.access" logger, creating a new one, using a middleware to collect and print the new data. You can check a draft here: https://github.com/Kludex/uvicorn-logger |
|
Conceptually, this PR is wrong. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check comments on: Kludex#5Unfortunately, I've deleted my fork, and lost all the comments I made. There were a lot of them! 😢There's still an issue: my idea was to not remove the default formatter, but I'm unable to make it work with them.
I need help here. I've been on this problem for some time now, and the values in the
recordcopyseems correct, but I lost the default colors...