Add --timeout-graceful-shutdown
parameter
#1824
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
--timeout-graceful-shutdown
parameter, which sets a timeout on tasks that the server is waiting to perform theshutdown
lifespan event.This timeout doesn't act on the
shutdown
lifespan event i.e. theshutdown
event is supposed to run even in the scenario the tasks are timed out.I need to think of a nice test for this. Ideas?
Notes
The
--graceful-timeout
fromgunicorn
is conceptually different from--timeout-graceful-shutdown
. The first forcefully kills the worker, and the latter cancels the tasks that are running afteruvicorn
said "I'm not receiving more requests, I'm just going to finish some tasks".An alternative name for this parameter could be
--timeout-tasks-shutdown
, or similar.The logs are horrible when a task is cancelled. Should it be fine tho? 🤷
Missing
--graceful-timeout
fromgunicorn
.