From 4825656be24157beb6e4b225f2520704f650a0a7 Mon Sep 17 00:00:00 2001
From: "Mark S. Miller" <erights@gmail.com>
Date: Mon, 26 Aug 2024 13:29:43 -0700
Subject: [PATCH] fixup! review suggestions

---
 .github/workflows/ci.yml  | 51 ---------------------------------------
 packages/ses/package.json |  3 +--
 2 files changed, 1 insertion(+), 53 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index c7cab2fc75..b1ebc83ee2 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -231,57 +231,6 @@ jobs:
       - name: Run yarn test262
         run: exit 0 # TODO remove test262 from required tests for CI
 
-  platform-compatibility-test:
-    name: platform-compatibility-test
-
-    # begin macro
-
-    runs-on: ${{ matrix.platform }}
-    strategy:
-      fail-fast: false
-      matrix:
-        node-version: [18.x, 20.x]
-        platform: [ubuntu-latest]
-
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v3
-
-      # without this, setup-node errors on mismatched yarn versions
-      - run: corepack enable
-
-      - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v3
-        with:
-          node-version: ${{ matrix.node-version }}
-          cache: yarn
-
-      - name: Echo node version
-        run: node --version
-
-      - name: Install dependencies
-        run: yarn install --immutable
-
-      # end macro
-
-      - name: 'build'
-        run: yarn run build
-
-      # fails under Node v17
-      - run: corepack disable
-
-      - name: 'switch to node v18'
-        uses: actions/setup-node@v3
-        with:
-          node-version: '18.x'
-
-      - name: Echo node version
-        run: node --version
-
-      - name: Run test:platform-compatibility
-        # npm b/c Yarn 4 doesn't work in Node 18
-        run: cd packages/ses && npm run test:platform-compatibility
-
   viable-release:
     name: viable-release
 
diff --git a/packages/ses/package.json b/packages/ses/package.json
index 9448632975..c6da369318 100644
--- a/packages/ses/package.json
+++ b/packages/ses/package.json
@@ -72,8 +72,7 @@
     "lint:types": "tsc",
     "prepare": "npm run clean && npm run build",
     "qt": "ava",
-    "test": "tsd && ava",
-    "test:platform-compatibility": "node test/package/test.cjs"
+    "test": "tsd && ava"
   },
   "dependencies": {
     "@endo/env-options": "workspace:^"