Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ses-ava should not mix exports and side-effects #1467

Closed
gibson042 opened this issue Jan 25, 2023 · 1 comment
Closed

ses-ava should not mix exports and side-effects #1467

gibson042 opened this issue Jan 25, 2023 · 1 comment
Assignees
@gibson042
Labels
kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024

Comments

@gibson042
Copy link
Contributor

(split from #1235)

Agoric/agoric-sdk#5774

Motivation

Hacks around side-effects of prepare-test-env-ava such as #1439 (comment)

Acceptance criteria

  • module imports either have side-effects OR bindings
This was referenced Jan 25, 2023
Closed
Merged
@turadg turadg mentioned this issue Aug 3, 2023
Merged
@turadg turadg mentioned this issue Aug 16, 2023
Merged
@kriskowal kriskowal added the kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024 label Jan 8, 2024
@turadg turadg mentioned this issue Feb 23, 2024
Merged
This was referenced Feb 24, 2024
Closed
Merged
@erights erights mentioned this issue Mar 4, 2024
Open
@turadg turadg mentioned this issue Mar 12, 2024
Merged
1 task
@turadg
Copy link
Member

turadg commented Mar 12, 2024

closing per #2133 (comment)

@turadg turadg closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gibson042 gibson042

Labels
kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@turadg @kriskowal @gibson042