feat(daemon): Add reverseLocate() and followLocatorNameChanges()
#2195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
force-pushed
the
rekmarks-multi-bimap-fixes
branch
from
aec68a5 to
13bbec1
Compare
rekmarks
force-pushed
the
rekmarks-follow-reverse-locate
branch
from
1929957 to
cb91afe
Compare
rekmarks
force-pushed
the
rekmarks-multi-bimap-fixes
branch
from
13bbec1 to
89524a3
Compare
rekmarks
force-pushed
the
rekmarks-follow-reverse-locate
branch
from
cb91afe to
62a2efe
Compare
rekmarks
force-pushed
the
rekmarks-follow-reverse-locate
branch
2 times, most recently
from
b3b7c9c to
9784695
Compare
rekmarks
changed the title
reverseLocate() and followLocatorNames()reverseLocate() and followLocatorNameChanges()
rekmarks
commented
Apr 11, 2024
rekmarks
force-pushed
the
rekmarks-follow-reverse-locate
branch
from
aa8be0b to
2b6fd73
Compare
kriskowal
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Worth considering whether we might just factor a light-client out of followLocatorNameChanges that is based on a sharable subscription to followNameChanges. That might put the tracking burden closer to where it ought to be and relax the need to perform timely identifier GC.
| @@ -97,6 +97,30 @@ export const makeDirectoryMaker = ({ | |||
| return formatLocator(id, formulaType); | |||
| }; | |||
|
|
|||
| /** @type {import('./types.js').EndoDirectory['reverseLocate']} */ | |||
| const reverseLocate = async locator => { | |||
There was a problem hiding this comment.
Silly idea:
- “locate” means “get locator for name”
- “nominate” means “get name from locator”
Adds reverseLocate() to the directory. Also refactors locator utilities for better coherence with their formula identifier equivalents. Adds idFromLocator().
Adds an initial implementation of `followLocatorNameChanges()`, which publishes the extant names for a specific id, if any. Tests are added for the same.
Ensures that overwriting names during pet store renames publishes a removal event. The removal event(s) will always be published first. The behavior is tested both for overwrites and non-overwrites.
Replaces all references to "diff" in pubsub type names to "name change" to match the names of the pubsub APIs (e.g. `followNameChanges`). Also removes an extraneous `if` condition.
rekmarks
force-pushed
the
rekmarks-follow-reverse-locate
branch
from
2b6fd73 to
37bb657
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
reverseLocate()andfollowLocatorNameChanges()to the daemon's directory. To match this new method, the directory'sfollowChanges()and the pet store's underlyingfollow()are renamed tofollowNameChanges().The directory's
reverseLocate(locator)andfollowLocatorNameChanges(locator)are backed up by the pet store'sreverseIdentify(id)andfollowIdNameChanges(id), respectively. The implementation of the former is very straightforward. The implementation of the latter required the introduction of a new pubsub topic,idChangesTopic, and a map from ids toidChangesTopicsubscriptions (one for each id).Since the pet store is unaware of whether ids exist,
followIdNameChanges()will naively create a subscription that first publishes an empty array of names, and then any subsequent names that are added for that id.followLocatorNameChanges()inherits this property.The current implementation suffers from the limitation that locator name change subscriptions cannot be ended. A follow-up will introduce the ability for subscribers to cancel their subscription. Locator subscriptions will also be a target for our future garbage collector, which will delete subscriptions for unreachable locators. Cancelling a locator should not end the subscription, because we consider the liveness of a value to be orthogonal to the subscriber's interest in changes to its names.