fix: Delete obsolete platform-compatibility-test #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
changed the base branch from
master
to
markm-repair-arraybuffer-transfer
erights
changed the title
erights
force-pushed
the
markm-repair-arraybuffer-transfer-2
branch
from
6d1b625 to
b324de6
Compare
erights
changed the base branch from
markm-repair-arraybuffer-transfer
to
master
erights
force-pushed
the
markm-repair-arraybuffer-transfer-2
branch
from
b324de6 to
fc32323
Compare
kriskowal
requested changes
Aug 22, 2024
There was a problem hiding this comment.
The platform compatibility test specifically validates that SES works on Node.js 12 and can be deleted since it has vanished into history. Node.js 12 required special consideration because of its experimental ESM support. I would not mind following that down to the roots: The test:platform-compatibility script in the ses package.json can be deleted, as well as the test/package fixture.
erights
force-pushed
the
markm-repair-arraybuffer-transfer-2
branch
from
fc32323 to
4825656
Compare
Done. PTAL |
erights
changed the title
kriskowal
approved these changes
Aug 27, 2024
erights
force-pushed
the
markm-repair-arraybuffer-transfer-2
branch
from
a3840c7 to
ca4b5fb
Compare
erights
added a commit
that referenced
this pull request
Sep 4, 2024
Staged on #2419 Closes: #XXXX Refs: #2414 #2418 #2419 ## Description #2414 by itself does not work on Node 18 and Node 20 because - those platforms do not have `Array.prototype.transfer`, so #2414 must use `structuredClone` instead - `structuredClone` does exist on Node >= 18, so it should be on supported platforms (though see #2418 ). However, `structuredClone` itself is dangerous and so must not be added to the shared intrinsics. As a result, in #2414 , when `@endo/pass-style` is initialized in a created compartment, it fails to find either `Array.prototype.transfer` and `structuredClone To solve this, @kriskowal suggested that we also shim `Array.prototype.transfer` if needed during `lockdown`, along with other repairs. We are avoiding similarly shimming `Array.prototype.transferToImmutable` because it is not yet standard. But `Array.prototype.transfer` is standard, and so `lockdown` can globally shim it before hardening the shared intrinsics. This PR implements @kriskowal 's suggestion. ### Security Considerations none ### Scaling Considerations by itself, none ### Documentation Considerations nothing signicant. ### Testing Considerations See #2418 . Aside from that, none ### Compatibility and Upgrade Considerations On platforms with neither `Array.prototype.transfer` nor a global `structuredClone`, the ses-shim will *currently* not install an emulation of `Array.prototype.transfer`. However, once we verify that endo is not intended to support platforms without both, we may change lockdown to throw, failing to lock down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2418
Refs: #2417 #1308
Description
Adapted from #2419 (review) below
The platform compatibility test specifically validates that SES works on Node.js 12 and can be deleted since it has vanished into history. Node.js 12 required special consideration because of its experimental ESM support. Delete the
test:platform-compatibilityscript in the sespackage.json, as well as thetest/packagefixture in ci.ymlImmediate motivation explained in #2418 , #2417 broken the platform-compatibility-test tests because it depends on the platform providing either
Array.prototype.transferorstructuredClone. Node supportstransferstarting with Node 22, but supportsstructuredClonestarting in Node 18. That should be fine, since that is our declared support floor. This PR changes our one known remaining dependence on Node 12.Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none beyond the need to explain our platform requirements, which this PR does not change.
Testing Considerations
The point. This PR only affects tests, not production code.
Reviewers, should this PR be labeled
test:instead offix:?Compatibility and Upgrade Considerations
After this PR, we will no longer notice further breakage on Node < 18. That fits with our declared support floor.