From 9e314e0085b3f398056e7e67861d95014c8bf00f Mon Sep 17 00:00:00 2001
From: n-vr <43145188+n-vr@users.noreply.github.com>
Date: Tue, 26 Sep 2023 10:53:58 +0200
Subject: [PATCH] fix: implement workaround for known GPIO issue

GPIO 36 and 39 trigger false ISR's in esp-idf v4.2.0.
This caused the button task to run too much, starving other tasks.

See https://github.com/espressif/esp-idf/issues/1096.
---
 src/util/buttons.cpp | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/util/buttons.cpp b/src/util/buttons.cpp
index 1d3ce9b..d6ceaee 100644
--- a/src/util/buttons.cpp
+++ b/src/util/buttons.cpp
@@ -26,6 +26,14 @@ namespace Buttons
          */
         void IRAM_ATTR ISRHandlerGPIO(void *pvParams)
         {
+            auto button = reinterpret_cast<Button *>(pvParams);
+
+            // Button was not actually pressed.
+            // This is a workaround for a know error for some GPIO's with the ISR in esp-idf v4.4.0.
+            // See https://github.com/espressif/esp-idf/issues/1096.
+            if (gpio_get_level(button->gpioNum) != button->trigger)
+                return;
+
             xQueueSendFromISR(s_gpioEventQueue, pvParams, NULL);
         }