Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check to the asyncCollections to not process the data if api returns with 204 #567

Merged
merged 3 commits into from
Apr 27, 2022

Conversation

Jlu18
Copy link
Member

@Jlu18 Jlu18 commented Apr 26, 2022

This prevents the unhandled rejection error.

@Jlu18 Jlu18 requested review from banthedev, jdones01 and a team April 26, 2022 19:51
Copy link
Member

@banthedev banthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, short and sweet 👍

@banthedev banthedev merged commit 5f53ed6 into engaging-computing:dev Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants