Skip to content

Commit cbec816

Browse files
[ci] Enable LUCI legacy analysis (flutter#4435)
Enables the new analyze_legacy targets in LUCI, and removes the Cirrus version. Part of flutter#114373
1 parent 1999cdc commit cbec816

File tree

2 files changed

+0
-24
lines changed

2 files changed

+0
-24
lines changed

.ci.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -231,15 +231,13 @@ targets:
231231
# Analyze with the previous stable (N-1) and the stable before that (N-2). The
232232
# versions in `channel` should be updated after a new major stable release.
233233
- name: Linux analyze_legacy N-1
234-
bringup: true # New target
235234
recipe: packages/packages
236235
timeout: 30
237236
properties:
238237
target_file: analyze_legacy.yaml
239238
channel: "3.7.12"
240239

241240
- name: Linux analyze_legacy N-2
242-
bringup: true # New target
243241
recipe: packages/packages
244242
timeout: 30
245243
properties:

.cirrus.yml

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -69,28 +69,6 @@ task:
6969
- else
7070
- ./script/tool_runner.sh federation-safety-check
7171
- fi
72-
# Does a sanity check that packages at least pass analysis on the N-1 and N-2
73-
# versions of Flutter stable if the package claims to support that version.
74-
# This is to minimize accidentally making changes that break old versions
75-
# (which we don't commit to supporting, but don't want to actively break)
76-
# without updating the constraints.
77-
# Note: The versions below should be manually updated after a new stable
78-
# version comes out.
79-
- name: legacy_version_analyze
80-
matrix:
81-
# Change the arguments to pubspec-check when changing these values.
82-
env:
83-
CHANNEL: "3.7.12"
84-
env:
85-
CHANNEL: "3.3.10"
86-
package_prep_script:
87-
# Allow analyzing packages that use a dev dependency with a higher
88-
# minimum Flutter/Dart version than the package itself.
89-
- ./script/tool_runner.sh remove-dev-dependencies
90-
analyze_script:
91-
# Only analyze lib/; non-client code doesn't need to work on
92-
# all supported legacy version.
93-
- ./script/tool_runner.sh analyze --lib-only --skip-if-not-supporting-flutter-version="$CHANNEL" --custom-analysis=script/configs/custom_analysis.yaml
9472
- name: readme_excerpts
9573
env:
9674
CIRRUS_CLONE_SUBMODULES: true

0 commit comments

Comments
 (0)