Skip to content

Commit 11bfb3c

Browse files
[web] Re-enable test now that source of flakiness is fixed (#140462)
The test was flaky before due to overflowing GPU memory during the test. The memory leak was fixed here flutter/engine#49214 Fixes flutter/flutter#137669 As a side effect of the fix, this test also runs much faster, from about 3 minutes on my Macbook down to about 25 seconds. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
1 parent 7b0bfa8 commit 11bfb3c

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

packages/flutter/test/cupertino/text_field_test.dart

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8390,13 +8390,10 @@ void main() {
83908390
final EditableText editableText = tester.firstWidget(find.byType(EditableText));
83918391
expect(editableText.clipBehavior, Clip.none);
83928392

8393-
// TODO(harryterkelsen): see https://github.com/flutter/flutter/issues/137669
8394-
if (!kIsWeb || !isCanvasKit) {
8395-
await expectLater(
8396-
find.byKey(const ValueKey<int>(1)),
8397-
matchesGoldenFile('overflow_clipbehavior_none.cupertino.0.png'),
8398-
);
8399-
}
8393+
await expectLater(
8394+
find.byKey(const ValueKey<int>(1)),
8395+
matchesGoldenFile('overflow_clipbehavior_none.cupertino.0.png'),
8396+
);
84008397
});
84018398

84028399
testWidgets('can shift + tap to select with a keyboard (Apple platforms)', (WidgetTester tester) async {

0 commit comments

Comments
 (0)