Skip to content

Commit 1c52436

Browse files
authored
Skip integration tests that consistently OOM on a Windows platform. (#160368)
Towards flutter/flutter#157640. As far as I can tell, these test cases add no value to be running specifically on Windows (they are testing general tool functionality), and it's on [Windows specifically that the tests have the most problems with OOM and timeout](https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Windows%20tool_integration_tests_2_9).
1 parent ad4a121 commit 1c52436

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

packages/flutter_tools/test/integration.shard/android_plugin_skip_unsupported_test.dart

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5+
import 'dart:io';
6+
57
import 'package:file_testing/file_testing.dart';
68
import 'package:flutter_tools/src/base/file_system.dart';
7-
import 'package:flutter_tools/src/base/io.dart';
89
import 'package:flutter_tools/src/cache.dart';
910

1011
import '../src/common.dart';
@@ -104,7 +105,7 @@ void main() {
104105
expect(buildApkResult.stderr.toString(),
105106
isNot(contains('Please fix your settings.gradle')));
106107
expect(buildApkResult, const ProcessResultMatcher());
107-
});
108+
}, skip: Platform.isWindows); // https://github.com/flutter/flutter/issues/157640
108109

109110
test(
110111
'skip plugin with android folder if it does not support the Android platform',
@@ -137,7 +138,7 @@ void main() {
137138
'flakes.',
138139
);
139140
}
140-
});
141+
}, skip: Platform.isWindows); // https://github.com/flutter/flutter/issues/157640
141142

142143
// TODO(54566): Remove test when issue is resolved.
143144
/// Test project with a `settings.gradle` (PluginEach) that apps were created
@@ -152,7 +153,7 @@ void main() {
152153
expect(buildApkResult.stderr.toString(),
153154
isNot(contains('Please fix your settings.gradle')));
154155
expect(buildApkResult, const ProcessResultMatcher());
155-
});
156+
}, skip: Platform.isWindows); // https://github.com/flutter/flutter/issues/157640
156157

157158
// TODO(54566): Remove test when issue is resolved.
158159
/// Test project with a `settings.gradle` (PluginEach) that apps were created
@@ -168,7 +169,7 @@ void main() {
168169
expect(buildApkResult.stderr.toString(),
169170
isNot(contains('Please fix your settings.gradle')));
170171
expect(buildApkResult, const ProcessResultMatcher());
171-
});
172+
}, skip: Platform.isWindows); // https://github.com/flutter/flutter/issues/157640
172173

173174
// TODO(54566): Remove test when issue is resolved.
174175
/// Test project with a `settings.gradle` (PluginEach) that apps were created
@@ -188,7 +189,7 @@ void main() {
188189
const ProcessResultMatcher(
189190
stderrPattern: 'Please fix your settings.gradle'),
190191
);
191-
});
192+
}, skip: Platform.isWindows); // https://github.com/flutter/flutter/issues/157640
192193
}
193194

194195
const String pubspecWithPluginPath = r'''

0 commit comments

Comments
 (0)