Skip to content

Commit 4f35112

Browse files
authored
Updated eglConfigChoose error message and error clause. (#161178)
fixes flutter/flutter#160806 - The error message will never say success anymore. - The error clause is slightly more permissive. If this resolves the issue though, the driver for the emulator has a bug in it since it shouldn't return `success` and zero configs. It's probably just indicating that it successfully found zero apropos configs. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent 7141c2a commit 4f35112

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

engine/src/flutter/impeller/toolkit/egl/display.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
#include <vector>
88

9+
#include "flutter/fml/logging.h"
910
#include "impeller/toolkit/egl/context.h"
1011
#include "impeller/toolkit/egl/surface.h"
1112

@@ -161,8 +162,7 @@ std::unique_ptr<Config> Display::ChooseConfig(ConfigDescriptor config) const {
161162
return nullptr;
162163
}
163164

164-
if (config_count_out != 1u) {
165-
IMPELLER_LOG_EGL_ERROR;
165+
if (config_count_out < 1) {
166166
return nullptr;
167167
}
168168

0 commit comments

Comments
 (0)