Skip to content

Commit 600ee30

Browse files
authored
Move integration_test.FlutterDeviceScreenshotTest to the framework slow shard (#164398)
Closes flutter/flutter#164177. [Every](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8721680858175088673/+/u/run_test.dart_for_framework_tests_shard_and_subshard_misc/stdout) [recent](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8721678607671718689/+/u/run_test.dart_for_framework_tests_shard_and_subshard_misc/stdout) [failure](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8721668796723786737/+/u/run_test.dart_for_framework_tests_shard_and_subshard_misc/stdout) is `integration_test.FlutterDeviceScreenshotTest`, which is run using Gradle, and often takes 5m+. This test is already [close to hitting its threshold of 30m consistently](https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Windows%20framework_tests_misc): ![Image](https://github.com/user-attachments/assets/e05fa1af-c431-4960-b08b-c3ceebc75f85) I am proposing moving this test to `Linux framework_tests_slow`, it does not have a lot of value to run on every platform, and is indeed, slow.
1 parent 1bafd3e commit 600ee30

File tree

1 file changed

+30
-29
lines changed

1 file changed

+30
-29
lines changed

dev/bots/suite_runners/run_framework_tests.dart

Lines changed: 30 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -247,6 +247,36 @@ Future<void> frameworkTestsRunner() async {
247247
await runFixTests('integration_test');
248248
await runFixTests('flutter_driver');
249249
await runPrivateTests();
250+
251+
// Run java unit tests for integration_test
252+
//
253+
// Generate Gradle wrapper if it doesn't exist.
254+
Process.runSync(
255+
flutter,
256+
<String>['build', 'apk', '--config-only'],
257+
workingDirectory: path.join(
258+
flutterRoot,
259+
'packages',
260+
'integration_test',
261+
'example',
262+
'android',
263+
),
264+
);
265+
await runCommand(
266+
path.join(flutterRoot, 'packages', 'integration_test', 'example', 'android', 'gradlew$bat'),
267+
<String>[
268+
':integration_test:testDebugUnitTest',
269+
'--tests',
270+
'dev.flutter.plugins.integration_test.FlutterDeviceScreenshotTest',
271+
],
272+
workingDirectory: path.join(
273+
flutterRoot,
274+
'packages',
275+
'integration_test',
276+
'example',
277+
'android',
278+
),
279+
);
250280
}
251281

252282
Future<void> runMisc() async {
@@ -289,35 +319,6 @@ Future<void> frameworkTestsRunner() async {
289319
'--exclude-tags=web',
290320
],
291321
);
292-
// Run java unit tests for integration_test
293-
//
294-
// Generate Gradle wrapper if it doesn't exist.
295-
Process.runSync(
296-
flutter,
297-
<String>['build', 'apk', '--config-only'],
298-
workingDirectory: path.join(
299-
flutterRoot,
300-
'packages',
301-
'integration_test',
302-
'example',
303-
'android',
304-
),
305-
);
306-
await runCommand(
307-
path.join(flutterRoot, 'packages', 'integration_test', 'example', 'android', 'gradlew$bat'),
308-
<String>[
309-
':integration_test:testDebugUnitTest',
310-
'--tests',
311-
'dev.flutter.plugins.integration_test.FlutterDeviceScreenshotTest',
312-
],
313-
workingDirectory: path.join(
314-
flutterRoot,
315-
'packages',
316-
'integration_test',
317-
'example',
318-
'android',
319-
),
320-
);
321322
await runFlutterTest(path.join(flutterRoot, 'packages', 'flutter_goldens'));
322323
await runFlutterTest(path.join(flutterRoot, 'packages', 'flutter_localizations'));
323324
await runFlutterTest(path.join(flutterRoot, 'packages', 'flutter_test'));

0 commit comments

Comments
 (0)