Skip to content

Commit cd316dd

Browse files
authored
[web_benchmarks] Migrate to PlatformDispatcher API (flutter#3512)
[web_benchmarks] Migrate to PlatformDispatcher API
1 parent e893fdc commit cd316dd

File tree

3 files changed

+12
-7
lines changed

3 files changed

+12
-7
lines changed

packages/web_benchmarks/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.1.0+3
2+
3+
* Migrates from SingletonFlutterWindow to PlatformDispatcher API.
4+
15
## 0.1.0+2
26

37
* Updates code to fix strict-cast violations.

packages/web_benchmarks/lib/src/recorder.dart

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ abstract class SceneBuilderRecorder extends Recorder {
238238
final Completer<Profile> profileCompleter = Completer<Profile>();
239239
_profile = Profile(name: name);
240240

241-
window.onBeginFrame = (_) {
241+
PlatformDispatcher.instance.onBeginFrame = (_) {
242242
try {
243243
startMeasureFrame(profile);
244244
onBeginFrame();
@@ -247,22 +247,23 @@ abstract class SceneBuilderRecorder extends Recorder {
247247
rethrow;
248248
}
249249
};
250-
window.onDrawFrame = () {
250+
PlatformDispatcher.instance.onDrawFrame = () {
251251
try {
252252
_profile.record('drawFrameDuration', () {
253253
final SceneBuilder sceneBuilder = SceneBuilder();
254254
onDrawFrame(sceneBuilder);
255255
_profile.record('sceneBuildDuration', () {
256256
final Scene scene = sceneBuilder.build();
257257
_profile.record('windowRenderDuration', () {
258-
window.render(scene);
258+
// TODO(goderbauer): Migrate to PlatformDispatcher.implicitView once v3.9.0 is the oldest supported Flutter version.
259+
window.render(scene); // ignore: deprecated_member_use
259260
}, reported: false);
260261
}, reported: false);
261262
}, reported: true);
262263
endMeasureFrame();
263264

264265
if (shouldContinue()) {
265-
window.scheduleFrame();
266+
PlatformDispatcher.instance.scheduleFrame();
266267
} else {
267268
profileCompleter.complete(_profile);
268269
}
@@ -271,7 +272,7 @@ abstract class SceneBuilderRecorder extends Recorder {
271272
rethrow;
272273
}
273274
};
274-
window.scheduleFrame();
275+
PlatformDispatcher.instance.scheduleFrame();
275276
return profileCompleter.future;
276277
}
277278
}
@@ -391,7 +392,7 @@ abstract class WidgetRecorder extends Recorder implements FrameRecorder {
391392
reported: true);
392393

393394
if (shouldContinue()) {
394-
window.scheduleFrame();
395+
PlatformDispatcher.instance.scheduleFrame();
395396
} else {
396397
for (final VoidCallback fn in _didStopCallbacks) {
397398
fn();

packages/web_benchmarks/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: web_benchmarks
22
description: A benchmark harness for performance-testing Flutter apps in Chrome.
33
repository: https://github.com/flutter/packages/tree/main/packages/web_benchmarks
44
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+web_benchmarks%22
5-
version: 0.1.0+2
5+
version: 0.1.0+3
66

77
environment:
88
sdk: ">=2.17.0 <4.0.0"

0 commit comments

Comments
 (0)