Remove dead code in tools tests (#104567)

Author: goderbauer

packages/flutter_tools/test/commands.shard/hermetic/attach_test.dart

@@ -5,7 +5,6 @@
 // @dart = 2.8
 
 import 'dart:async';
-import 'dart:io';
 
 import 'package:file/memory.dart';
 import 'package:flutter_tools/src/android/android_device.dart';
@@ -36,28 +35,8 @@ import 'package:vm_service/vm_service.dart' as vm_service;
 import '../../src/common.dart';
 import '../../src/context.dart';
 import '../../src/fake_devices.dart';
-import '../../src/fake_vm_services.dart';
 import '../../src/test_flutter_command_runner.dart';
 
-final vm_service.Isolate fakeUnpausedIsolate = vm_service.Isolate(
-  id: '1',
-  pauseEvent: vm_service.Event(
-    kind: vm_service.EventKind.kResume,
-    timestamp: 0
-  ),
-  breakpoints: <vm_service.Breakpoint>[],
-  exceptionPauseMode: null,
-  isolateFlags: <vm_service.IsolateFlag>[],
-  libraries: <vm_service.LibraryRef>[],
-  livePorts: 0,
-  name: 'test',
-  number: '1',
-  pauseOnExit: false,
-  runnable: true,
-  startTime: 0,
-  isSystemIsolate: false,
-);
-
 void main() {
   tearDown(() {
     MacOSDesignedForIPadDevices.allowDiscovery = false;
@@ -688,108 +667,6 @@ Future<void> expectLoggerInterruptEndsTask(Future<void> task, StreamLogger logge
   );
 }
 
-VMServiceConnector getFakeVmServiceFactory({
-  @required Completer<void> vmServiceDoneCompleter,
-}) {
-  assert(vmServiceDoneCompleter != null);
-
-  return (
-    Uri httpUri, {
-    ReloadSources reloadSources,
-    Restart restart,
-    CompileExpression compileExpression,
-    GetSkSLMethod getSkSLMethod,
-    PrintStructuredErrorLogMethod printStructuredErrorLogMethod,
-    CompressionOptions compression,
-    Device device,
-    Logger logger,
-  }) async {
-    final FakeVmServiceHost fakeVmServiceHost = FakeVmServiceHost(
-      requests: <VmServiceExpectation>[
-        FakeVmServiceRequest(
-          method: kListViewsMethod,
-          args: null,
-          jsonResponse: <String, Object>{
-            'views': <Object>[
-              <String, Object>{
-                'id': '1',
-                'isolate': fakeUnpausedIsolate.toJson(),
-              },
-            ],
-          },
-        ),
-        FakeVmServiceRequest(
-          method: 'getVM',
-          args: null,
-          jsonResponse: vm_service.VM.parse(<String, Object>{})
-            .toJson(),
-        ),
-        FakeVmServiceRequest(
-          method: '_createDevFS',
-          args: <String, Object>{
-            'fsName': globals.fs.currentDirectory.absolute.path,
-          },
-          jsonResponse: <String, Object>{
-            'uri': globals.fs.currentDirectory.absolute.path,
-          },
-        ),
-        FakeVmServiceRequest(
-          method: kListViewsMethod,
-          args: null,
-          jsonResponse: <String, Object>{
-            'views': <Object>[
-              <String, Object>{
-                'id': '1',
-                'isolate': fakeUnpausedIsolate.toJson(),
-              },
-            ],
-          },
-        ),
-      ],
-    );
-    return fakeVmServiceHost.vmService;
-  };
-}
-
-class TestHotRunnerFactory extends HotRunnerFactory {
-  HotRunner _runner;
-
-  @override
-  HotRunner build(
-    List<FlutterDevice> devices, {
-    String target,
-    DebuggingOptions debuggingOptions,
-    bool benchmarkMode = false,
-    File applicationBinary,
-    bool hostIsIde = false,
-    String projectRootPath,
-    String packagesFilePath,
-    String dillOutputPath,
-    bool stayResident = true,
-    bool ipv6 = false,
-    FlutterProject flutterProject,
-  }) {
-    _runner ??= HotRunner(
-      devices,
-      target: target,
-      debuggingOptions: debuggingOptions,
-      benchmarkMode: benchmarkMode,
-      applicationBinary: applicationBinary,
-      hostIsIde: hostIsIde,
-      projectRootPath: projectRootPath,
-      dillOutputPath: dillOutputPath,
-      stayResident: stayResident,
-      ipv6: ipv6,
-    );
-    return _runner;
-  }
-
-  Future<void> exitApp() async {
-    assert(_runner != null);
-    await _runner.exit();
-  }
-}
-
 class FakeDartDevelopmentService extends Fake implements DartDevelopmentService {
   @override
   Future<void> get done => noopCompleter.future;

packages/flutter_tools/test/commands.shard/hermetic/custom_devices_test.dart

@@ -163,13 +163,6 @@ const String defaultConfigLinux2 = r'''
 }
 ''';
 
-final Platform linuxPlatform = FakePlatform(
-  environment: <String, String>{
-    'FLUTTER_ROOT': linuxFlutterRoot,
-    'HOME': '/',
-  }
-);
-
 final Platform windowsPlatform = FakePlatform(
   operatingSystem: 'windows',
   environment: <String, String>{

packages/flutter_tools/test/commands.shard/hermetic/doctor_test.dart

@@ -19,7 +19,6 @@ import 'package:flutter_tools/src/android/android_studio_validator.dart';
 import 'package:flutter_tools/src/android/android_workflow.dart';
 import 'package:flutter_tools/src/base/file_system.dart';
 import 'package:flutter_tools/src/base/logger.dart';
-import 'package:flutter_tools/src/base/platform.dart';
 import 'package:flutter_tools/src/base/terminal.dart';
 import 'package:flutter_tools/src/base/user_messages.dart';
 import 'package:flutter_tools/src/build_info.dart';
@@ -42,11 +41,6 @@ import '../../src/context.dart';
 import '../../src/fakes.dart';
 import '../../src/test_flutter_command_runner.dart';
 
-final Platform macPlatform = FakePlatform(
-  operatingSystem: 'macos',
-  environment: <String, String>{'HOME': '/foo/bar'}
-);
-
 void main() {
   FakeFlutterVersion flutterVersion;
   BufferLogger logger;

packages/flutter_tools/test/commands.shard/hermetic/run_test.dart

@@ -801,14 +801,6 @@ class FakeAndroidSdk extends Fake implements AndroidSdk {
   String get adbPath => 'adb';
 }
 
-class TestRunCommand extends RunCommand {
-  @override
-  // ignore: must_call_super
-  Future<void> validateCommand() async {
-    devices = await globals.deviceManager.getDevices();
-  }
-}
-
 // Unfortunately Device, despite not being immutable, has an `operator ==`.
 // Until we fix that, we have to also ignore related lints here.
 // ignore: avoid_implementing_value_types

packages/flutter_tools/test/general.shard/android/gradle_test.dart

@@ -17,7 +17,6 @@ import 'package:flutter_tools/src/build_info.dart';
 import 'package:flutter_tools/src/cache.dart';
 import 'package:flutter_tools/src/globals.dart' as globals;
 import 'package:flutter_tools/src/project.dart';
-import 'package:test/fake.dart';
 
 import '../../src/common.dart';
 import '../../src/context.dart';
@@ -704,12 +703,3 @@ flutter:
     // TODO(zanderso): This is an integration test and should be moved to the integration shard.
   }, skip: true); // https://github.com/flutter/flutter/issues/87922
 }
-
-class FakeGradleUtils extends GradleUtils {
-  @override
-  String getExecutable(FlutterProject project) {
-    return 'gradlew';
-  }
-}
-
-class FakeAndroidSdk extends Fake implements AndroidSdk { }

packages/flutter_tools/test/general.shard/base/file_system_test.dart

@@ -183,4 +183,3 @@ class FakeProcessSignal extends Fake implements io.ProcessSignal {
   @override
   Stream<io.ProcessSignal> watch() => controller.stream;
 }
-class FakeFile extends Fake implements File { }

packages/flutter_tools/test/general.shard/build_system/targets/android_test.dart

@@ -10,7 +10,6 @@ import 'package:flutter_tools/src/artifacts.dart';
 import 'package:flutter_tools/src/base/deferred_component.dart';
 import 'package:flutter_tools/src/base/file_system.dart';
 import 'package:flutter_tools/src/base/logger.dart';
-import 'package:flutter_tools/src/base/platform.dart';
 import 'package:flutter_tools/src/build_info.dart';
 import 'package:flutter_tools/src/build_system/build_system.dart';
 import 'package:flutter_tools/src/build_system/depfile.dart';
@@ -21,7 +20,6 @@ import '../../../src/common.dart';
 import '../../../src/context.dart';
 import '../../../src/fake_process_manager.dart';
 
-final Platform platform = FakePlatform();
 void main() {
   FakeProcessManager processManager;
   FileSystem fileSystem;

packages/flutter_tools/test/general.shard/build_system/targets/icon_tree_shaker_test.dart

@@ -6,7 +6,6 @@ import 'package:file/memory.dart';
 import 'package:flutter_tools/src/artifacts.dart';
 import 'package:flutter_tools/src/base/file_system.dart';
 import 'package:flutter_tools/src/base/logger.dart';
-import 'package:flutter_tools/src/base/platform.dart';
 import 'package:flutter_tools/src/build_info.dart';
 import 'package:flutter_tools/src/build_system/build_system.dart';
 import 'package:flutter_tools/src/build_system/targets/icon_tree_shaker.dart';
@@ -16,7 +15,6 @@ import '../../../src/common.dart';
 import '../../../src/fake_process_manager.dart';
 import '../../../src/fakes.dart';
 
-final Platform kNoAnsiPlatform = FakePlatform();
 const List<int> _kTtfHeaderBytes = <int>[0, 1, 0, 0, 0, 15, 0, 128, 0, 3, 0, 112];
 
 const String inputPath = '/input/fonts/MaterialIcons-Regular.otf';

packages/flutter_tools/test/general.shard/build_system/targets/windows_test.dart

@@ -9,7 +9,6 @@ import 'package:file_testing/file_testing.dart';
 import 'package:flutter_tools/src/artifacts.dart';
 import 'package:flutter_tools/src/base/file_system.dart';
 import 'package:flutter_tools/src/base/logger.dart';
-import 'package:flutter_tools/src/base/platform.dart';
 import 'package:flutter_tools/src/build_info.dart';
 import 'package:flutter_tools/src/build_system/build_system.dart';
 import 'package:flutter_tools/src/build_system/depfile.dart';
@@ -20,11 +19,6 @@ import 'package:flutter_tools/src/convert.dart';
 import '../../../src/common.dart';
 import '../../../src/context.dart';
 
-final Platform kWindowsPlatform = FakePlatform(
-  operatingSystem: 'windows',
-  environment: <String, String>{},
-);
-
 void main() {
   testWithoutContext('UnpackWindows copies files to the correct windows/ cache directory', () async {
     final Artifacts artifacts = Artifacts.test();

packages/flutter_tools/test/general.shard/cache_test.dart

@@ -1062,19 +1062,6 @@ class FakeSimpleArtifact extends CachedArtifact {
   Future<void> updateInner(ArtifactUpdater artifactUpdater, FileSystem fileSystem, OperatingSystemUtils operatingSystemUtils) async { }
 }
 
-class FakeDownloadedArtifact extends CachedArtifact {
-  FakeDownloadedArtifact(this.downloadedFile, Cache cache) : super(
-    'fake',
-    cache,
-    DevelopmentArtifact.universal,
-  );
-
-  final File downloadedFile;
-
-  @override
-  Future<void> updateInner(ArtifactUpdater artifactUpdater, FileSystem fileSystem, OperatingSystemUtils operatingSystemUtils) async { }
-}
-
 class FakeSecondaryCachedArtifact extends Fake implements CachedArtifact {
   bool upToDate = false;
   bool didUpdate = false;