This repository has been archived by the owner on Dec 28, 2021. It is now read-only.
Cache dependencies for CI. #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kesanov
added
Category: Performance
Difficulty: Core Contributor
farmaazon
suggested changes
Mar 23, 2020
There was a problem hiding this comment.
I would like to some more refactoring here: The workflow is called like "Build (Windows Linux, MacOs)" but on branches it does not build packages (and not on each system), but only do the checking and tests. I'd like to have it in a separate workflows, like "Check" and "Package (Windows,Linux,MacOs)"
farmaazon
approved these changes
Mar 23, 2020
wdanilo
reviewed
Mar 23, 2020
wdanilo
approved these changes
Mar 25, 2020
mwu-tow
pushed a commit
to enso-org/enso
that referenced
this pull request
Oct 30, 2021
Original commit: enso-org/ide@4e55dc5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR introduces cache for github actions.
The job
Checkis now mac-only, to deal with the limited size of cache (5GB).Wasm-pack is now download from github (faster by 3.5 minutes compared to cargo install).
Clippy was replaced with
clippy-reviewdue to rust-lang/rust-clippy#4612.There is also some issue with cache mechanism: actions/cache#227. But so far it wasn't very frequent (it happened once in 15 runs).
Checklist
Please include the following checklist in your PR: