Update raise stmt #360
Merged
Update raise stmt #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvkersch
reviewed
Jun 27, 2017
chaco/plot.py
Outdated
| raise ValueError, "Don't know how to create PlotData for data" \ | ||
| "of type " + str(type(data)) | ||
| raise ValueError("Don't know how to create PlotData for data" | ||
| "of type {!s}".format(type(data))) |
There was a problem hiding this comment.
You probably don't need the explicit !s specifier here.
mdickinson
reviewed
Jun 27, 2017
chaco/plot.py
Outdated
| raise ValueError, "Don't know how to create PlotData for data" \ | ||
| "of type " + str(type(data)) | ||
| raise ValueError("Don't know how to create PlotData for data" | ||
| "of type {}".format(type(data))) |
There was a problem hiding this comment.
Do we care about Python 2.6? I assume not, but we should probably make that explicit somewhere.
(If we do care about Python 2.6, this needs to be {0} rather than {}.)
There was a problem hiding this comment.
While you're here, you could also fix the missing space between "data" and "of".
There was a problem hiding this comment.
we only test with 2.7 but I guess the README is where this information belongs best?
and add a missing space modified: README.rst modified: chaco/plot.py
jvkersch
reviewed
Jun 27, 2017
README.rst
Outdated
| @@ -42,6 +42,7 @@ Features | |||
|
|
|||
| Prerequisites | |||
| ------------- | |||
| Chaco is only supported on Python 2.7.x and Python > 3.3. | |||
There was a problem hiding this comment.
Maybe Python >= 3.4 is more clear, or something like Python 3.4 and up?
|
LGTM. @jvkersch? |
|
LGTM too. The Travis failures seem unrelated. |
|
merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.