FEAT: Add DataFramePlotData. #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should add pandas to the CI requirements |
|
Thanks for the tip. it took a few tries to get it right. :) Code + example + tests (passing) = ready for review and merge |
jvkersch
reviewed
Jul 19, 2017
chaco/data_frame_plot_data.py
Outdated
| """ A PlotData implementation class that handles a DataFrame. | ||
|
|
||
| By default, it doesn't allow its input data to be modified by downstream | ||
| Chaco components or interactors. The index is availble as data unless there |
There was a problem hiding this comment.
I cannot spell that word right. I need to either stop using it or spell check every time I do. :D
|
Any other suggestions? |
|
Looks great to me! Esp. the demo. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for you, @jonathanrocher. It needs a bit more testing around 'index' and an example.