Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: support renderer traits #514

Merged
merged 4 commits into from
Mar 10, 2020
Merged

Feature: support renderer traits #514

merged 4 commits into from
Mar 10, 2020

Conversation

jonathanrocher
Copy link
Collaborator

These factory functions are used all over the place in the demos. This PR adds:

  1. docstrings for the factory functions.
  2. unit tests for the factory functions.
  3. a **renderer_traits argument to support passing more renderer traits through the factory.

Even though my eyes bleed, I am refraining from adding pep8 fixes to keep the PR clean.

jvkersch
jvkersch approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@jvkersch jvkersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

chaco/tests/test_plot_factory.py Outdated Show resolved Hide resolved
@jonathanrocher
Copy link
Collaborator Author

Thanks for the review @jvkersch ! Will merge once CI is happy.

@jonathanrocher jonathanrocher merged commit 192675d into master Mar 10, 2020
@jonathanrocher jonathanrocher deleted the feature/support_renderer_traits branch March 10, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvkersch jvkersch jvkersch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanrocher @jvkersch