ENH: Setup online redirect and proper index page for docset #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds doc2dash flags to: - set the online redirect url (-u) so one can go from the local docsets to the online ones. - Set the index page (-I) to show `index.html`, which is what is showed online, instead of the index of all the names.
|
LGTM! I verified that the docsets build and I can load them into Zeal, with the desired changes. The build fails because we are still testing on Python 2.7... I will rip this out, but this PR can be merged in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds doc2dash flags to:
-u) so one can go from the local docsets to the online ones.-I) to showindex.html, which is what is showed online, instead of the index of all the names.