Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle index=None in ScatterInspector #540

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Handle index=None in ScatterInspector #540

merged 1 commit into from
Nov 13, 2020

Conversation

notmatthancock
Copy link
Contributor

Closes #26

corranwebster
corranwebster approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@corranwebster corranwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulporuri
Copy link
Contributor

Thanks for the fix @notmatthancock . Do you need a bugfix release of chaco to make use of this in the near future (within a month)?

@notmatthancock
Copy link
Contributor Author

Do you need a bugfix release of chaco to make use of this in the near future (within a month)?

Sure. We're working around it, but we could remove our workaround code with a release.

@notmatthancock notmatthancock merged commit b8bd324 into master Nov 13, 2020
@notmatthancock notmatthancock deleted the fix/scatter-inspector-deselect branch November 13, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corranwebster corranwebster corranwebster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ScatterInspector does not deselect all on index == None
3 participants
@notmatthancock @rahulporuri @corranwebster