Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EOF file markers #579

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Remove EOF file markers #579

merged 2 commits into from
Mar 24, 2021

Conversation

rahulporuri
Copy link
Contributor

This PR removes the silly/outdated EOF markers in source files.

Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulporuri
Copy link
Contributor Author

i'll hold off on merging this until all of your chaco removal/changes are addressed/merged because there will be a bunch of merge conflicts.

@rahulporuri
Copy link
Contributor Author

@aaronayres35 merging this even though only 2 of your PRs got merged and the other two will now see merge conflicts.

@rahulporuri rahulporuri merged commit e342361 into master Mar 24, 2021
@rahulporuri rahulporuri deleted the cln/remove-eof-markers branch March 24, 2021 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants