Replace use of depends_on in Traits Properties with observe #630
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces almost all uses of
depends_on
with observe, aside from this:chaco/chaco/base_1d_plot.py
Line 40 in 99109d9
changing this line resulted in he following errors:
Note that the trait is changed twice with observe.
assertTraitChanges
conveniently provides the events that were triggered. Printing these for one of the tests, we see:ie the exact same event is occurring twice.
I spent a bit of time trying to understand this, but still am not sure where the problem is coming from.
For now, I figure we can go ahead with the rest of the changes and save this for another day.
Additionally, this PR also changes a property to observe
selected_mask
notselection_mask
as noselection_mask
is defined on the class butselected_mask
is (I assume this was the original intention, +1 for observe catching a potential silent bug).