Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use @property decorator instead of property function #651

Merged
merged 2 commits into from
Apr 13, 2021
Merged

Use @property decorator instead of property function #651

merged 2 commits into from
Apr 13, 2021

Conversation

aaronayres35
Copy link
Contributor

closes #609

This PR simply updates the uses of the property function to use the @property decorator. Also, users of the property now access the property without calling the get____ or set___ methods.

rahulporuri
rahulporuri approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronayres35 aaronayres35 merged commit c9090c0 into master Apr 13, 2021
@aaronayres35 aaronayres35 deleted the use-property-decorator branch April 13, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulporuri rahulporuri rahulporuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use @property decorator instead of property function
2 participants
@aaronayres35 @rahulporuri