fix windows/pyqt test_dont_crash_on_click failure #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to have done the trick? 🤞 (windows pyqt job has passed) |
aaronayres35
changed the title
This was referenced Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix the CI failure observed here: #633 (comment) and #649 (comment)
TBH I do not understand the error entirely yet. It doesn't make sense to me that '_QtWindow' object has no attribute 'handler' as it is explicitly defined in the
__init__method of '_QtWindow' . Further I don't get how that would be a windows specific problem....Nonetheless, the error is occurring in a
leaveEventmethod. This PR is really a hunch (I don't have a windows machine so I am opening the PR to see if it actually fixes the problem). I changed the coordinates of the drag in the test to hopefully avoid any sort ofleaveEventoccurring. Leaving the window is actually not the intended behavior of the test anyway.I am not sure why a leaveEvent was ever getting triggered in the first place as the view being tested explicitly sets
height = 500,width = 500.