Kill chaco.shell and related code #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #463
This PR incrementally removes all uses of
chaco.shellfrom the code base. It may be useful to review commit by commit.It starts by removing the entire
chaco.shellsubpackage. It then removes theshellrelated examples. It also then removes thechaco.pluginsub package as the whole purpose of this subpackage was basically to define an envisage plugin that provideschaco.shellfunctionality. Withoutshellthis plugin becomes useless (AFAICT). It also removes these files from the list of flake8 ignored files in tox.ini.This does not completely solve #463 because much of the documentation still uses and refers to
chaco.shell. I will open a separate PR for scrapping shell from the docs after this.