Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hyetopgraph example #687

Merged
merged 7 commits into from
Apr 20, 2021
Merged

Update hyetopgraph example #687

merged 7 commits into from
Apr 20, 2021

Conversation

aaronayres35
Copy link
Contributor

@aaronayres35 aaronayres35 commented Apr 19, 2021

part of #660

sister PR to #680

This PR updates the Hyetograph example in the documentation. It removes the use of ChacoPlotItem and the like with ComponentEditor, replaces use of on_trait_change with observe, removes development setup section, cleans up wording, fixes bugs in the code, and adds the code for the example in examples/demo/hyetograph.py.

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM



Trait Definitions
=================

This application only requires one class that will contain the Traits
and mathematical calculations together. Classes that contain Traits
must inherit from the HasTraits class. Python's multiple
must inherit from the :class:`HasTraits` class. Python's multiple
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HasTraits or one of its subclasses.

@aaronayres35 aaronayres35 merged commit c4e8021 into master Apr 20, 2021
@aaronayres35 aaronayres35 deleted the update-hyetopgraph branch April 20, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants