Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ChacoPlotItem / ChacoPlotEditor #688

Merged
merged 6 commits into from
Apr 20, 2021
Merged

Conversation

aaronayres35
Copy link
Contributor

closes #660

This PR replaces the use of ChacoPlotItem in the data_stream.py example. The trait_editor example was entirely deleted as its purpose appeared to be to showcase the functionality of ChacoPlotItem/ChacoPlotEditor which we remove in this PR.

PRs #680 and #687 remove its use in the documentation examples.

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@@ -450,17 +450,6 @@ source: `tabbed_plots.py <https://github.com/enthought/chaco/tree/master/example
.. image:: example_images/tabbed_plots1.png
.. image:: example_images/tabbed_plots2.png

``traits_editor.py``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the information in this example is duplicated in other examples so no problem getting rid of it.

@rahulporuri rahulporuri changed the title Remove ChacoPlotItem / ChacoPlotIEditor Remove ChacoPlotItem / ChacoPlotEditor Apr 20, 2021
@aaronayres35 aaronayres35 merged commit c19afe9 into master Apr 20, 2021
@aaronayres35 aaronayres35 deleted the remove-ChacoPlotItem-etc branch April 20, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace use of ChacoPlotItem with just Item and ComponentEditor
2 participants