Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use mock through unittest #740

Merged
merged 2 commits into from
May 18, 2021
Merged

use mock through unittest #740

merged 2 commits into from
May 18, 2021

Conversation

aaronayres35
Copy link
Contributor

mock is now in the standard library since python 3.3. This PR updates the codebase to use mock via unittest.

Python 2 is end of life and we plan to drop support for 5.0.0 release

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronayres35 aaronayres35 merged commit 54a1b92 into master May 18, 2021
@aaronayres35 aaronayres35 deleted the remove-mock-imports branch May 18, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants