Replace bg_color with bgcolor #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronayres35
changed the title
rahulporuri
approved these changes
May 18, 2021
| @@ -79,7 +79,7 @@ class Demo(HasTraits): | |||
| Group( | |||
| Item( | |||
| "plot", | |||
| editor=ComponentEditor(size=size, bgcolor=bg_color), | |||
| editor=ComponentEditor(size=size, bgcolor=bgcolor), | |||
There was a problem hiding this comment.
FTR : ComponentEditor is the only place where I see someone set bgcolor on an enable AbstractWindow - and it sets bgcolor, not the deprecated bg_color.
| @@ -96,7 +96,6 @@ def _create_plot_component(): | |||
| # Attributes to use for the plot view. | |||
| size = (650, 650) | |||
| title = "Scatter plot with selection" | |||
| bg_color = "lightgray" | |||
There was a problem hiding this comment.
why not pass this to the ComponentEditor - like what we do in the other examples
There was a problem hiding this comment.
I can add that here in this PR. I deleted it just because previously this bg_color variable was just unused entirely.
It makes sense to actually use it though
| @@ -87,7 +87,6 @@ def _create_plot_component(): | |||
| # Attributes to use for the plot view. | |||
| size = (650, 650) | |||
| title = "Scatter plot with selection" | |||
| bg_color = "lightgray" | |||
There was a problem hiding this comment.
same comment as above - why not pass this to the ComponentEditor, like we do with the other examples
|
Here's the original commit where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: enthought/enable#816 (review)
This PR removes uses of the soon to be removed, deprecated
bg_colortrait from enable. For consistency it renames all uses ofbg_colorin the codebase withbgcolor(even just temp variables), in order to keep consistent. Note, all changes occur in example code