Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address deprecation warnings because of moved modules in chaco #786

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

rahulporuri
Copy link
Contributor

This PR addresses deprecation warnings raised in chaco because of the recent moves in chaco i.e. chaco.plots and chaco.overlays. Note that this PR needs to be backported to the maint/5.0 branch and included in the 5.0 release.

This commit addresses deprecation warnings raised in chaco because of
the recent moves in chaco i.e. chaco.plots and chaco.overlays

	modified:   chaco/base_2d_plot.py
	modified:   chaco/base_xy_plot.py
	modified:   chaco/plot.py
	modified:   chaco/selectable_legend.py
	modified:   chaco/tests/test_array_or_none.py
	modified:   chaco/tools/image_inspector_tool.py
	modified:   chaco/tools/regression_lasso.py
Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@rahulporuri rahulporuri merged commit 643ee44 into master Jun 15, 2021
@rahulporuri rahulporuri deleted the fix/deprecation-warnings-in-codebase branch June 15, 2021 11:56
rahulporuri pushed a commit that referenced this pull request Jun 15, 2021
…786)

This commit addresses deprecation warnings raised in chaco because of
the recent moves in chaco i.e. chaco.plots and chaco.overlays

	modified:   chaco/base_2d_plot.py
	modified:   chaco/base_xy_plot.py
	modified:   chaco/plot.py
	modified:   chaco/selectable_legend.py
	modified:   chaco/tests/test_array_or_none.py
	modified:   chaco/tools/image_inspector_tool.py
	modified:   chaco/tools/regression_lasso.py
rahulporuri pushed a commit that referenced this pull request Jun 15, 2021
	modified:   CHANGES.txt
rahulporuri pushed a commit that referenced this pull request Jun 15, 2021
* FIX : Address deprecation warnings because of moved modules in chaco (#786)

This commit addresses deprecation warnings raised in chaco because of
the recent moves in chaco i.e. chaco.plots and chaco.overlays

	modified:   chaco/base_2d_plot.py
	modified:   chaco/base_xy_plot.py
	modified:   chaco/plot.py
	modified:   chaco/selectable_legend.py
	modified:   chaco/tests/test_array_or_none.py
	modified:   chaco/tools/image_inspector_tool.py
	modified:   chaco/tools/regression_lasso.py

* DOC : Include #786 in changelog

	modified:   CHANGES.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants