Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hittest_tool.py example use of map_screen #808

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

aaronayres35
Copy link
Contributor

This example became broken by the recent changes to map_screen.
This change was pulled from #726
Note there are some other examples which did not get pulled into chaco/examples that could be fixed as well. I did not do that as I could not recall if they were planned to be deleted entirely. See #726 changes to examples/tutorials/...
I am happy to make those changes on this PR if need be.

@aaronayres35 aaronayres35 changed the title fix hittest_tool.py example fix hittest_tool.py example use of map_screen Jul 7, 2021
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Let's audit the other potentially broken examples later.

@aaronayres35 aaronayres35 merged commit 4ec968d into master Jul 8, 2021
@rahulporuri rahulporuri deleted the fix-examples-map_screen branch August 10, 2021 09:41
@corranwebster corranwebster added the needs backport Needs to be backported to current maint/* label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs backport Needs to be backported to current maint/*
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants