fix world_map demo with new link #864
Conversation
|
Can you add a comment to the example with the attribution of the image copyright. From wikimedia, it sounds like "Strebe, Public domain, via Wikimedia Commons" would be good and maybe a link to the page (https://commons.wikimedia.org/wiki/File:Winkel_triple_projection_SW.jpg) |
examples/demo/world_map.py
Outdated
| @@ -34,7 +38,7 @@ class WorldMapPlot(HasTraits): | |||
|
|
|||
| # The URL which points to the world map image to be downloaded | |||
| image_url = Str( | |||
| "http://eoimages.gsfc.nasa.gov/ve//2433/land_shallow_topo_2048.jpg" | |||
| "https://upload.wikimedia.org/wikipedia/commons/9/91/Winkel_triple_projection_SW.jpg" | |||
There was a problem hiding this comment.
This uses a different projection, and so the plotted points are not correct (eg. Austin will not be plotted correctly).
The original image is this one in Wikimedia: https://commons.wikimedia.org/wiki/File:Land_shallow_topo_2048.jpg
So this URL may be the right one to use (although it is very high resolution): https://upload.wikimedia.org/wikipedia/commons/9/91/Land_shallow_topo_2048.jpg
There was a problem hiding this comment.
And this is the source from NASA: https://visibleearth.nasa.gov/images/57752/blue-marble-land-surface-shallow-water-and-shaded-topography/57754l
So this may be even better: https://eoimages.gsfc.nasa.gov/images/imagerecords/57000/57752/land_shallow_topo_2048.jpg
There was a problem hiding this comment.
Thanks, just changed to "https://eoimages.gsfc.nasa.gov/images/imagerecords/57000/57752/land_shallow_topo_2048.jpg" as you proposed. I assume we don't need a copyright header since it's the same NASA image as before?
|
So, is this issue ready for close? |
|
|
|
Somehow I still cannot merge this due to CI test error (which comes from MacOS RuntimeError: NumPy was built with baseline optimizations: |
Yes, this is due to a change in the EDM mac numpy build. We need to turn off some of the mac tests. |
|
I've made the MacOS tests no longer required, so this should be able to be merged despite the failure. |
The chaco/examples/demo/world_map demo example is broken due to the original image link in the example has expired. This PR replaces it with a new example.