Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle nan in barplots. #895

Merged
merged 1 commit into from
May 16, 2023
Merged

Handle nan in barplots. #895

merged 1 commit into from
May 16, 2023

Conversation

corranwebster
Copy link
Contributor

@corranwebster corranwebster commented May 10, 2023 •
edited
Loading

Also somewhat better handling of cropping rectangles that are offscreen for common cases.

Includes basic tests.

Fixes #845

@corranwebster corranwebster marked this pull request as ready for review May 10, 2023 15:17
dpinte
dpinte approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@dpinte dpinte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corranwebster corranwebster merged commit e8d1473 into main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpinte dpinte dpinte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bar plot disappears and "Exceeded cell block limit" traceback when encountering NaN
2 participants
@corranwebster @dpinte