Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TextPlot when color, font or other aesthetics change. #905

Merged
merged 2 commits into from
May 16, 2023
Merged

Update TextPlot when color, font or other aesthetics change. #905

merged 2 commits into from
May 16, 2023

Conversation

corranwebster
Copy link
Contributor

Forces recreation of all the Label objects, which is suboptimal, but since this uses Label instances this is not a highly performant plot in any case.

Fixes #729

dpinte
dpinte approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@dpinte dpinte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@corranwebster corranwebster merged commit 034b227 into main May 16, 2023
@corranwebster corranwebster deleted the fix/text-plot-color-font branch May 16, 2023 15:51
@fred4ets
Copy link

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpinte dpinte dpinte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

changing TextPlot color & font
3 participants
@corranwebster @fred4ets @dpinte