-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font styles do not work on macOS #404
Comments
achabotl
added a commit
that referenced
this issue
Jun 9, 2020
This makes style and stretch case insensitive in `kiva.fonttools.font_manager.ttfFontProperty`. The case sensitivity led to font styles not being properly detected on (at least) macOS. The checks on filename were already case insensitive. Fixes: #404
This was referenced Jun 9, 2020
I think this may be a duplicate of #391. |
Yes, it's same root cause. |
achabotl
added a commit
that referenced
this issue
Dec 9, 2020
* FIX: Make style and stretch check case insensitive This makes style and stretch case insensitive in `kiva.fonttools.font_manager.ttfFontProperty`. The case sensitivity led to font styles not being properly detected on (at least) macOS. The checks on filename were already case insensitive. For testing, the "TestTTF Italic" font was edited in. FontForge [1] to have the style "Italic". [1]: https://fontforge.org/ Fixes: #404 Co-authored-by: Kit Yan Choi <kchoi@enthought.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Italic and bold fonts are no found on macOS. The cause is a case-sensitive check that the filename contains the string italic or bold. Fix incoming.
enable/kiva/fonttools/font_manager.py
Line 557 in 6cf525c
Here's a minimal example with the broken code.
The text was updated successfully, but these errors were encountered: