Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document behaviour of DragTool end_drag_on_leave #445

Closed
corranwebster opened this issue Nov 23, 2020 · 2 comments
Closed

Document behaviour of DragTool end_drag_on_leave #445

corranwebster opened this issue Nov 23, 2020 · 2 comments
Labels
ETS Backlog Good issue for ETS team members to look at

Comments

@corranwebster
Copy link
Contributor

corranwebster commented Nov 23, 2020 •
edited
Loading

end_drag_on_leave only has effect if capture_mouse is False (if the mouse is captured it never leaves the component). This may be confusing behaviour, although it is reasonable when the details are thought through. Probably best to add to this as a note to this comment:

enable/enable/tools/drag_tool.py

Lines 19 to 20 in 933fc55

# End the drag operation if the mouse leaves the associated component?
end_drag_on_leave = Bool(True)

@corranwebster corranwebster added the ETS Backlog Good issue for ETS team members to look at label Nov 23, 2020
@jwiggins
Copy link
Member

jwiggins commented Dec 1, 2020

Is this closed by #452?

@notmatthancock
Copy link
Contributor

Ah, sorry. I did not see this issue when I created #451 . Yes, this was closed by #452.

@jwiggins jwiggins closed this as completed Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ETS Backlog Good issue for ETS team members to look at
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jwiggins @corranwebster @notmatthancock