Python 3 Compatibility #209

corranwebster · 2015-09-11T19:03:20Z

Updated version of #137

Simple str-bytes/int-long conversions, remove type string functions from numeric.i absent in python3

- types.ListType -> list ... - migrate swig typemaps

Test was expecting ValueError, but an AssertionError was being raised. Also added kiva/tests/__init__.py so tat tests can be run from installation.

All unit tests now pass on python 3.3 and 2.7 on linux. Few integration tests segfault, as was the case before.

NOTE: The test file currently segfaults with gcc (4.8.2) possibly due to compiler bug on optimization level >= O1; use clang instead to compile kiva

Somehow, 2to3 is not always able to detect it, ,likely due to agg being an extension module.

Conflicts: enable/savage/svg/pathdata.py setup.py

…just on windows

…hon3 Conflicts: kiva/agg/__init__.py

…erged.

…ature/python3 Conflicts: .travis.yml enable/__init__.py integrationtests/kiva/agg/test_draw_dash.py kiva/fonttools/font.py kiva/fonttools/sstruct.py setup.py

corranwebster · 2015-09-11T19:45:23Z

Looks like kiwisolver isn't Python 3 compatible?

corranwebster · 2015-09-11T20:10:28Z

Yep, Kiwi solver doesn't support Python 3 yet, and probably won't soon. I'm guessing we can skip the constraints-based layout tests in the short-term, but the lack of the feature for Python 3 is a bit of a disappointment.

@jwiggins Thoughts on ways forward?

itziakos · 2015-09-14T17:32:43Z

@jwiggins and @corranwebster even with python3 support for kiwisolver we still have the problem that the kiwisolver depedency is not optionional.

corranwebster · 2015-09-22T18:09:39Z

@jwiggins and @itziakos Would it make sense to vendorize Kiwisolver inside enable.layout.*

itziakos · 2015-09-22T21:32:36Z

@jwiggins and @itziakos Would it make sense to vendorize Kiwisolver inside enable.layout.*

I think that vendorizing kiwisolver to solve the non-optional relationship with enable is wrong. Kiwisolver and the constrained based layout should be optional.

jwiggins · 2015-09-23T08:57:16Z

@itziakos: I agree that constraint-based layout should be optional.

I disagree that such an arrangement should be implemented here. This PR is for Python 3.

itziakos · 2015-09-23T10:04:49Z

I disagree that such an arrangement should be implemented here. This PR is for Python 3.

This is fine with me. I have created a new issue #212 for the task of making kiwisolver truly optional. However, please note that at the moment due to the fact that kiwisolver is not python 3 compatible, the resolution of #212 or nucleic/kiwi#13 are blocking this PR.

jwiggins · 2016-03-09T16:39:02Z

nucleic/kiwi#13 has now been merged! This PR can move forward.

Conflicts: .travis.yml

Conflicts: enable/viewport.py

corranwebster · 2016-05-17T10:02:46Z

Everything is passing. The native scrollbar tests are passing, but a bit dodgy---but then the native scrollbar is a bit dodgy. I'll open a ticket for that, ~~I don't think it's because this PR is bad~~ Update: it looks like this is a regression introduced by this PR. Will look more closely before we merge.

@jwiggins @itziakos Any show-stoppers that would prevent merging this?

itziakos · 2016-05-17T10:39:49Z

@corranwebster in Qt you need to run the event loop in order to destroy widgets, using process events will not work as expected (probably wait for the widget to be destroyed https://github.com/enthought/pyface/blob/master/pyface/ui/qt4/util/gui_test_assistant.py#L79)

codecov-io · 2016-05-17T11:04:59Z

Current coverage is 49.36%

Merging #209 into master will increase coverage by 14.01%

@@             master       #209   diff @@
==========================================
  Files           211        123     -88   
  Lines         18659      12828   -5831   
  Methods           0          0           
  Messages          0          0           
  Branches       2621       2045    -576   
==========================================
- Hits           6596       6332    -264   
+ Misses        11543       5936   -5607   
- Partials        520        560     +40

2 files in kiva/fonttools were modified. more
- Misses +13
- Hits +14
3 files in kiva were modified. more
- Misses +8
- Partials +2
- Hits -10
11 files in enable were modified. more
- Misses +195
- Partials -8
- Hits -73
2 files (not in diff) in kiva/fonttools were deleted. more
2 files (not in diff) in kiva were deleted. more
2 files (not in diff) in ...ble/trait_defs/ui/wx were deleted. more
3 files (not in diff) in enable/trait_defs/ui were deleted. more
1 files (not in diff) in enable/trait_defs were deleted. more
2 files (not in diff) in ...nable/tools/toolbars were deleted. more
6 files (not in diff) in enable/tools were deleted. more

Powered by Codecov. Last updated by 29a676d...7678b91

corranwebster · 2016-05-17T12:14:25Z

There appears to be a Heisenbug in the viewport_test_case.py test cases under Python 3. Simply re-running can get the tests to pass. I can occasionally get a replication locally when running in Python 3.

itziakos · 2016-05-17T12:19:54Z

There appears to be a Heisenbug in the viewport_test_case.py test cases under Python 3. Simply re-running can get the tests to pass. I can occasionally get a replication locally when running in Python 3.

It is possible that a number of object deletions and other events are leaking between tests and that can result in unsuspected behavior and timeouts down the line. I would open an issue about the random failure. We need to cleanup the testing infra and make sure that tests do not leak widgets in the Qt ar Wx application singletons

itziakos · 2016-05-17T12:23:48Z

@corranwebster do you still want to keep the workaround on making kiwisolver optional (see coordinate_box)? As far as I understand now that kiwisolver supports python3 we can delegate making kiwisolver optional at a later time.

corranwebster · 2016-05-17T12:24:09Z

It's replicable just running that test case alone; so its not leakage from other tests; although it could be leakage from within the one test.

corranwebster · 2016-05-17T12:27:15Z

I'm OK with making it optional being in here even if kiwisolver now supports Python 3. We can revisit later if needed.

jwiggins · 2016-05-17T12:56:16Z

@corranwebster: 👍 from my end

corranwebster · 2016-05-17T13:06:41Z

Looks like it is an initialisation order issue for the Heisenbug: the order in which traits get set at start-up time seems variable under Python 3, and if you get the wrong order then you can end up with bad results.

I will merge this, and open an issue for the bug, as it's not a 5 minute fix, by the look of it.

corranwebster · 2016-05-17T13:10:16Z

See #228 for issue.

Pankaj Pandey and others added 27 commits October 24, 2013 03:22

setup.py: Import distutils.command.clean necessary to load it.

16a97ae

py3: Port extensions/swig.i to python3.

f71529e

Simple str-bytes/int-long conversions, remove type string functions from numeric.i absent in python3

enable 2to3 in setup

f5c4012

Use 23o3 in setup and migrate other code manually to python3

bfce49e

- types.ListType -> list ... - migrate swig typemaps

Refactor: import Image -> from PIL import Image

e88b0ff

Fix some font loading issues and py3 string conversions.

ab00095

Run 2to3 on tests

b10c3e1

TESTS: Raise ValueError in GraphicsContextArray.__init__

87a8120

Test was expecting ValueError, but an AssertionError was being raised. Also added kiva/tests/__init__.py so tat tests can be run from installation.

Tests: Fix tests for running on python 3.

6c7a098

All unit tests now pass on python 3.3 and 2.7 on linux. Few integration tests segfault, as was the case before.

TST: Fix image_test_case.py for python3

f6c608b

NOTE: The test file currently segfaults with gcc (4.8.2) possibly due to compiler bug on optimization level >= O1; use clang instead to compile kiva

Py3: Use relative import in agg.__init__

c1dd869

Somehow, 2to3 is not always able to detect it, ,likely due to agg being an extension module.

Py3: Run 2to3 on examples.

e479300

Merge branch 'python3' of https://github.com/pankajp/enable into python3

4788919

Conflicts: enable/savage/svg/pathdata.py setup.py

fixed a small python 3 compilation problem in kiva/agg swig wrapper, …

290ca55

…just on windows

Fix porting stuff. Passes all tests.

ddcab28

Merge branch 'master' of https://github.com/enthought/enable into pyt…

7cad911

…hon3 Conflicts: kiva/agg/__init__.py

[TRAVIS] Setup build system for Python 3. Start using built PySide eggs.

7e143c1

[TRAVIS] Install Pillow instead of PIL, Install PyParsing.

c317002

[TRAVIS] Use ported versions of PyFace and TraitsUI, until they are m…

f9ebd93

…erged.

[TRAVIS] Move to build/lib in Python 3, Remove unused files.

27798db

[TRAVIS] Switch to "setup.py nosetests"

b43ef76

[TRAVIS] Use package names instead of directory paths.

a3801cf

Merge branch 'python3' of https://github.com/pradyunsg/enable into fe…

84f22ef

…ature/python3 Conflicts: .travis.yml enable/__init__.py integrationtests/kiva/agg/test_draw_dash.py kiva/fonttools/font.py kiva/fonttools/sstruct.py setup.py

Add 2to3 to build.

adbd446

Fix travis.yml

d9b1876

Make build wheel script executable.

d444ced

Give up on 2.6 for now.

46ccdef

Remove kiwisolver dependency for 3.4

38ce2f9

jwiggins and others added 6 commits March 11, 2016 11:34

Merge branch 'master' into feature/python3

22a0658

Conflicts: .travis.yml

Merge branch 'master' into feature/python3

0b3cd68

Merge branch 'master' into feature/python3

aee0efe

Conflicts: enable/viewport.py

Fix PIL/Pillow issues.

3a8082f

Travis not skipping wx on Python 3.4. Potential fix.

563fa44

Merge branch 'master' into feature/python3

6af8a55

corranwebster added 3 commits May 17, 2016 11:12

Remove scrollbar in a better way in tests.

6a47e11

Try an alternative way to remove errors.

0bfdb3f

Pump extra events through the event loop when testing scrollbar.

7678b91

Start to fold in pyface qt4 test helpers.

37e5d14

corranwebster merged commit d5720c0 into master May 17, 2016

corranwebster deleted the feature/python3 branch May 17, 2016 13:10

rahulporuri mentioned this pull request Feb 26, 2021

Fix KeySpec.from_string #638

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Python 3 Compatibility #209

Python 3 Compatibility #209

corranwebster commented Sep 11, 2015

corranwebster commented Sep 11, 2015

corranwebster commented Sep 11, 2015

itziakos commented Sep 14, 2015

corranwebster commented Sep 22, 2015

itziakos commented Sep 22, 2015

jwiggins commented Sep 23, 2015

itziakos commented Sep 23, 2015

jwiggins commented Mar 9, 2016

corranwebster commented May 17, 2016 •

edited

Loading

itziakos commented May 17, 2016 •

edited

Loading

codecov-io commented May 17, 2016

corranwebster commented May 17, 2016 •

edited

Loading

itziakos commented May 17, 2016

itziakos commented May 17, 2016

corranwebster commented May 17, 2016

corranwebster commented May 17, 2016

jwiggins commented May 17, 2016

corranwebster commented May 17, 2016

corranwebster commented May 17, 2016

Python 3 Compatibility #209

Python 3 Compatibility #209

Conversation

corranwebster commented Sep 11, 2015

corranwebster commented Sep 11, 2015

corranwebster commented Sep 11, 2015

itziakos commented Sep 14, 2015

corranwebster commented Sep 22, 2015

itziakos commented Sep 22, 2015

jwiggins commented Sep 23, 2015

itziakos commented Sep 23, 2015

jwiggins commented Mar 9, 2016

corranwebster commented May 17, 2016 • edited Loading

itziakos commented May 17, 2016 • edited Loading

codecov-io commented May 17, 2016

Current coverage is 49.36%

corranwebster commented May 17, 2016 • edited Loading

itziakos commented May 17, 2016

itziakos commented May 17, 2016

corranwebster commented May 17, 2016

corranwebster commented May 17, 2016

jwiggins commented May 17, 2016

corranwebster commented May 17, 2016

corranwebster commented May 17, 2016

corranwebster commented May 17, 2016 •

edited

Loading

itziakos commented May 17, 2016 •

edited

Loading

corranwebster commented May 17, 2016 •

edited

Loading