Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quartz CGGLContext #515

Merged
merged 3 commits into from
Jan 4, 2021
Merged

Conversation

corranwebster
Copy link
Contributor

Fixes #514. Requires #513 since CI won't get to this point without that change.

@codecov-io
Copy link

codecov-io commented Dec 24, 2020

Codecov Report

Merging #515 (cdb0705) into master (22cdf49) will increase coverage by 4.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #515      +/-   ##
==========================================
+ Coverage   30.71%   35.16%   +4.45%     
==========================================
  Files         210      210              
  Lines       17840    17840              
  Branches     2454     2454              
==========================================
+ Hits         5479     6274     +795     
+ Misses      12028    11161     -867     
- Partials      333      405      +72     
Impacted Files Coverage Δ
enable/null/image.py 0.00% <0.00%> (-85.72%) ⬇️
enable/component_editor.py 78.72% <0.00%> (-4.26%) ⬇️
enable/colors.py 39.56% <0.00%> (-3.30%) ⬇️
kiva/trait_defs/kiva_font_trait.py 79.68% <0.00%> (-3.13%) ⬇️
enable/tools/hover_tool.py 74.24% <0.00%> (-3.04%) ⬇️
enable/api.py 93.93% <0.00%> (ø)
kiva/fonttools/font_manager.py 56.41% <0.00%> (+0.61%) ⬆️
enable/component.py 55.29% <0.00%> (+0.64%) ⬆️
kiva/fonttools/font.py 50.00% <0.00%> (+3.94%) ⬆️
kiva/gl.py 34.91% <0.00%> (+34.91%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22cdf49...cdb0705. Read the comment docs.

Copy link
Member

@jwiggins jwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corranwebster corranwebster merged commit f8783c7 into master Jan 4, 2021
@corranwebster corranwebster deleted the fix/remove-quartz-CGGLContext branch January 4, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove CGGLContext from Quartz backend
3 participants