Link against system FreeType #556
Conversation
jwiggins
force-pushed
the
deps/system-freetype
branch
2 times, most recently
from
0029cfd
to
10e766d
Compare
setup.py
Outdated
| if sys.platform == 'win32': | ||
| # XXX: Note that Windows has used FreeType for many years. This would | ||
| # be a change in behavior. | ||
| define_macros += [('KIVA_USE_WIN32', None)] | ||
| agg_include_dirs += [os.path.join(agg_dir, 'font_win32_tt')] | ||
| kiva_agg_sources += [ | ||
| os.path.join(agg_dir, 'font_win32_tt', 'agg_font_win32_tt.cpp'), | ||
| ] |
There was a problem hiding this comment.
It's important to check that this doesn't change things too much on Windows. If it does, we'll have to figure out how to link against an external FreeType on Windows.
There was a problem hiding this comment.
Using the Win32 font rendering appears to break text rotation, according to @rahulporuri's testing
jwiggins
force-pushed
the
deps/system-freetype
branch
2 times, most recently
from
c697235
to
49df452
Compare
|
Looks like this is no deal on Windows. Apart from CI, I just tried testing this locally and I saw the same issue. |
|
The problem was that |
jwiggins
force-pushed
the
deps/system-freetype
branch
from
49df452
to
18aa5d7
Compare
jwiggins
force-pushed
the
deps/system-freetype
branch
2 times, most recently
from
457419c
to
d5e058f
Compare
|
OK. That took a few more tries than expected, but I've now shaken out the code rot in the |
|
Using the Win32 font renderer in Agg has bug related to affine transformations, so it's best to stick with the FreeType renderer. Unfortunately, that means a lot more complexity when compiling on Windows if we don't want to include a vendored copy of FreeType. I'm going to close this for now and we can revisit when we're not trying to get a release out the door. |
Closes #553
This is just the change to the build script. Another PR will remove the vendored code since that's a very big change.