-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for toolkit/backend selection #597
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, I built the docs locally and everything looked as expected. Links to ETSConfig in traits don't seem to actually give a link, but I don't think that is the fault of the changes in this PRR
--------- | ||
|
||
To control toolkit selection directly from application code, one must use | ||
:class:`~traits.etsconfig.etsconfig.ETSConfig`. Specifically, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason when I built the docs this doesn't link to https://docs.enthought.com/traits/traits_api_reference/traits.etsconfig.html?highlight=etsconfig#traits.etsconfig.etsconfig.ETSConfig
It just shows up bolded. The Pyface link to Toolkit
further down works as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is and the intersphinx_mapping
given above are correct though, so it may be unrelated to the changes here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that too. I'm not sure why it doesn't work.
explicitly specified. | ||
|
||
|
||
ETSConfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a suggested change:
It makes sense to have this section here, but some of this content should also happily sit in the traits docs. Currently the traits docs (outside of api documentation) have little to no mention of ETSConfig.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ref: enthought/traits#1427
When writing the traits docs in the future it may be useful to reference these docs / vice-versa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. Glad there's an issue in traits already.
Thanks for the quick review |
The banner feature here is an explanation of the
ETS_TOOLKIT
/ETSConfig.toolkit
mechanism for selecting the GUI toolkit and kiva backend used by an application. In addition to that, I made some minor additions/modifications in other parts of the documentation.