-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document GraphicsContext state #672
Conversation
@@ -17,4 +17,4 @@ | |||
gc.add_path(path) | |||
gc.fill_path() | |||
|
|||
gc.save("example.png") | |||
gc.save("compiled_path_ex.png") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes to this file seem unrelated to the main purpose of this PR, but even so the changes make sense as something we want to do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, it's not related. I had made a similar change in the new state example (which was copied from the compiled path example)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple nit picky comments and a request for a quick "why this is useful/powerful" concluding paragraph
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the feedback |
Closes #615